From owner-svn-src-head@freebsd.org  Thu Jun  1 17:16:43 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 192B1B7ACD1;
 Thu,  1 Jun 2017 17:16:43 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E10EC8337B;
 Thu,  1 Jun 2017 17:16:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 3B1B921BD; Thu,  1 Jun 2017 17:16:42 +0000 (UTC)
Date: Thu, 1 Jun 2017 17:16:42 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Simon J. Gerraty" <sjg@juniper.net>
Cc: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>,
 Marcel Moolenaar <marcel@FreeBSD.org>,
 src-committers <src-committers@FreeBSD.org>,
 svn-src-all@FreeBSD.org, Brooks Davis <brooks@FreeBSD.org>,
 svn-src-head@FreeBSD.org, Ngie Cooper <ngie@FreeBSD.org>
Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests
Message-ID: <20170601171642.GA601@FreeBSD.org>
References: <201705310801.v4V81CjO004032@repo.freebsd.org>
 <20170601050339.GA48398@spindle.one-eyed-alien.net>
 <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com>
 <84744.1496336318@kaos.jnpr.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <84744.1496336318@kaos.jnpr.net>
User-Agent: Mutt/1.8.2 (2017-04-18)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2017 17:16:43 -0000

On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote:
> One option would be to store a sha256 hash of the result.
> If the image generated by the test hashes to the correct value - you
> pass.

That should be preferred.  Storing binary blobs in VCS is bad practice.

> Of course if the test fails, you are completely in the dark as to
> how/why.

Not really: you checkout previous version (which produces correct hash)
and store generated image for later inspection and diffing.

> Is storing img-1x1-512-mbr.vmdk.gz any more palatable?

This is barely acceptable, but only if image was zerofied/sparsed prior
to compression.  Also, the image should be of the minimal (sufficient)
working size.

./danfe