From owner-svn-src-head@freebsd.org Tue Apr 26 21:37:58 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D06A8B1DE00 for ; Tue, 26 Apr 2016 21:37:58 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89A351967 for ; Tue, 26 Apr 2016 21:37:58 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qk0-x235.google.com with SMTP id r184so11248606qkc.1 for ; Tue, 26 Apr 2016 14:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jSWvWVqwnGYGWFaBoRzyrWnGZFDo9MtWT4Sx1Vavd34=; b=PTQo9wL1ZLhTlaPkXDsX5HheD5Jv7G+4vf7Rl7rMtJRUaL2BfYR8iq7kaI2+nLJ3CZ Put9D6jdu3cIFhWaeYUyYoU9wdIEQRqxurBewBziE2Psxrtj3cYjh8054ZxmfSHOH8wQ JonZc+f60Y5sBcOjdc/GLy3vILE0TO5tY9jt0UFijor+oon6mNnUIuBt7+Y07mff+P0c zlvBlDkXlgp4PNSZ649dImlA0sVbmyecvWjhrmNttv2eKA9Ur4BVfhlaOl47RLsyF2WU n6SFrFoONHC1vPQmXz+FOA2Ya/HLmU0mHgtQOslHUtzc0wpFqDoq/mdO8SVN1KPRn0cH 6VSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jSWvWVqwnGYGWFaBoRzyrWnGZFDo9MtWT4Sx1Vavd34=; b=QZiW+6Ul0lBgIX8CqhcJB/nODh1ZY8XDtCmY4W8p9ktbcshN8ExAhnTvk8TM3M5bSS 8VwEeO3egp89Epl/IxrAXuFfLTRtG+OIz0VYcBydw2DwcIcnkoYUqbTTUryzBEO0fg0C R9UNx8wzPSiPZHPdEjgVl+aNrA0X7J7hZ1SfpEupDrEJ1bW/bcjwkdf1s7jjaORITiTz 8CfY99mpDhTrknpZUPR8G2lq6k/Z5S0HSGAenOltCdj+D0zdjHQErA7R3xhOJKKbqqI7 gRLGZBjkYCy830AKedMxHOeKcWKwuykp6X518llSI1Q4SA4gzAgnfFL2rKszRmkVrdh3 x+IA== X-Gm-Message-State: AOPr4FWYTV1ta9KgQfprGw7Kx4jMwJ6aJzOqIImyCBMpooGf/L/y2tMx21NCTWCAuqvMCT8z X-Received: by 10.55.42.145 with SMTP id q17mr4953463qkq.159.1461706677612; Tue, 26 Apr 2016 14:37:57 -0700 (PDT) Received: from mutt-hardenedbsd (c-73-135-80-144.hsd1.md.comcast.net. [73.135.80.144]) by smtp.gmail.com with ESMTPSA id y85sm232558qha.32.2016.04.26.14.37.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Apr 2016 14:37:56 -0700 (PDT) Date: Tue, 26 Apr 2016 17:37:54 -0400 From: Shawn Webb To: Kristof Provost Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298664 - head/sys/fs/msdosfs Message-ID: <20160426213754.GD13055@mutt-hardenedbsd> References: <201604262036.u3QKaWto038435@repo.freebsd.org> <20160426210138.GA13055@mutt-hardenedbsd> <2190C480-1B7A-47F8-BFB4-D7C8E6F25385@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6Nae48J/T25AfBN4" Content-Disposition: inline In-Reply-To: <2190C480-1B7A-47F8-BFB4-D7C8E6F25385@FreeBSD.org> X-Operating-System: FreeBSD mutt-hardenedbsd 11.0-CURRENT-HBSD FreeBSD 11.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 21:37:58 -0000 --6Nae48J/T25AfBN4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2016 at 11:05:38PM +0200, Kristof Provost wrote: >=20 > > On 26 Apr 2016, at 23:01, Shawn Webb wrote: > >=20 > > On Tue, Apr 26, 2016 at 08:36:32PM +0000, Kristof Provost wrote: > >> Author: kp > >> Date: Tue Apr 26 20:36:32 2016 > >> New Revision: 298664 > >> URL: https://svnweb.freebsd.org/changeset/base/298664 > >>=20 > >> Log: > >> msdosfs: Prevent buffer overflow when expanding win95 names > >>=20 > >> In win2unixfn() we expand Windows 95 style long names. In some cases = that > >> requires moving the data in the nbp->nb_buf buffer backwards to make = room. That > >> code failed to check for overflows, leading to a stack overflow in wi= n2unixfn(). > >>=20 > >> We now check for this event, and mark the entire conversion as failed= in that > >> case. This means we present the 8 character, dos style, name instead. > >>=20 > >> PR: 204643 > >> Differential Revision: https://reviews.freebsd.org/D6015 > >=20 > > Will this be MFC'd? Since it's triggerable as non-root, should this have > > a CVE? Though the commit log shows technical comments, it doesn't show > > related security information. >=20 > Yes, I???ll put MFCing this on my todo list. When do you plan to MFC? --=20 Shawn Webb HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --6Nae48J/T25AfBN4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXH9+wAAoJEGqEZY9SRW7uMIoP/1nsAPZZxMOh9AGsY2XxDK30 rK6TTSunMueANUVY8P25xrHlt6pIkneUDZbiFglhQt+S0LVvbisXuPxQrMnomYvw Nrn+HhaWtCL0YjYSF9wIeX6aO4qJwpABFMrgs5rpnczFVAMU2gBTW2G1GdoF6CPm l0i+0gumvgI37Mqz1gowjFN/eIQLFr/qiugqG9ubBn3UwD5Shx5VCxeMGyGXzsuK PA05Q65ScG6Mv675R4Mig9saChvBLUOrXPblu+WN+62JlvaHfyxx1Y5q8CLmGUdE 0xqQpqvmRxzP41uQyMQYjDnoOilyMiAPiXc4DMZMY4XXaNls3oP9PRltCmYxw9Pz aV+in6PfdJ5bJeHsuUk/00VnkaS97SfLN5w+c/1EE+uVeGDexyulT2wJPuzho724 bo3hVWILpPc9vylAn+T1uTDh5XhHJyf/Su9Bb6J9YPitI5MYhI5qS+w3w7PFToqC D6o5cYznfq6M4PASGXD4T1YBuGeOHzTr8IPdxskKJiMAGgGCPcYTyuJKj2dxtffw TxhaEfg+YxIrRiK8iv+WUu0uxscQAPqxzoLatjBujGqko3RfB3UCkhQ4TdmVYmXL bRtaWwayxHh5q7zv0djOcVu9QbqtIQ7lNCGYm+el3Vu0jDfQoe0vCRkjF0SIntzP /tt0VGkq3YkapavIHxzp =i2Th -----END PGP SIGNATURE----- --6Nae48J/T25AfBN4--