From owner-freebsd-net@FreeBSD.ORG Mon Mar 5 17:58:44 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F2C6106566B for ; Mon, 5 Mar 2012 17:58:44 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id CF0B08FC12 for ; Mon, 5 Mar 2012 17:58:43 +0000 (UTC) Received: by bkcjc3 with SMTP id jc3so4631565bkc.13 for ; Mon, 05 Mar 2012 09:58:42 -0800 (PST) Received-SPF: pass (google.com: domain of hiren.panchasara@gmail.com designates 10.205.127.130 as permitted sender) client-ip=10.205.127.130; Authentication-Results: mr.google.com; spf=pass (google.com: domain of hiren.panchasara@gmail.com designates 10.205.127.130 as permitted sender) smtp.mail=hiren.panchasara@gmail.com; dkim=pass header.i=hiren.panchasara@gmail.com Received: from mr.google.com ([10.205.127.130]) by 10.205.127.130 with SMTP id ha2mr11355618bkc.28.1330970322616 (num_hops = 1); Mon, 05 Mar 2012 09:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=da3LbADkVGD9nZaWiQ1f8tYXZUnDVzUzQnxf2/J4css=; b=jpr3PXSinNUddEG6o7JqWYoBh8XQpkNSOvhmAk5BzV0knpazDmED7L/MLyIjFiStQA IgHEIFfJ+B+K/aoNHscoQ5sUz5okW0KbRnUXR0yO5/PHsYayQCDdW2cCh7yxKAt/P+6z 7wK6S3NKa6djS9y61fAUYF4YQ3knKwVtPpaz26r52Gw5BCgQRD0436QzIIOAqfhuGX2/ lcfgowzhBjtR0RX96sp9i3pYejqx89fq3gu/21crEjcmaw2l+F7XvMY04cb92Tis7rTR /HQU8LK531AnR+u9ghk7kr0B6iJ/sh6fZzSYuyc84GCPeBfkwc7UpP2lySNNJ3PXYjpF /tMA== MIME-Version: 1.0 Received: by 10.205.127.130 with SMTP id ha2mr9013486bkc.28.1330970322518; Mon, 05 Mar 2012 09:58:42 -0800 (PST) Received: by 10.204.230.5 with HTTP; Mon, 5 Mar 2012 09:58:42 -0800 (PST) In-Reply-To: References: Date: Mon, 5 Mar 2012 09:58:42 -0800 Message-ID: From: hiren panchasara To: Andrew Thompson Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-net@freebsd.org Subject: Re: bridge interface type X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2012 17:58:44 -0000 On Sun, Mar 4, 2012 at 11:14 PM, Andrew Thompson wrote: > Here is a patch that changes it but I do not know what may break. > Thanks a lot Andrew. So, someone might be relying on interface type of bridge being IFT_ETHER? Who can confirm if this is a good patch? > > Index: if_bridge.c > =================================================================== > --- if_bridge.c (revision 232321) > +++ if_bridge.c (working copy) > @@ -568,6 +568,7 @@ bridge_clone_create(struct if_clone *ifc, int unit > { > struct bridge_softc *sc, *sc2; > struct ifnet *bifp, *ifp; > + struct sockaddr_dl *sdl; > int fb, retry; > unsigned long hostid; > > @@ -642,6 +643,8 @@ bridge_clone_create(struct if_clone *ifc, int unit > /* Now undo some of the damage... */ > ifp->if_baudrate = 0; > ifp->if_type = IFT_BRIDGE; > + sdl = (struct sockaddr_dl *)ifp->if_addr->ifa_addr; > + sdl->sdl_type = IFT_BRIDGE; > > mtx_lock(&bridge_list_mtx); > LIST_INSERT_HEAD(&bridge_list, sc, sc_list); > Appreciate your help, Hiren