From owner-freebsd-current@FreeBSD.ORG  Wed Aug 27 15:40:01 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 81B2A16A4BF
	for <freebsd-current@FreeBSD.ORG>;
	Wed, 27 Aug 2003 15:40:01 -0700 (PDT)
Received: from melusine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org
	[62.212.105.185])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 969C643FBF
	for <freebsd-current@FreeBSD.ORG>;
	Wed, 27 Aug 2003 15:40:00 -0700 (PDT)
	(envelope-from thomas@FreeBSD.ORG)
Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000)
	id 9C81E2C3D1; Thu, 28 Aug 2003 00:39:59 +0200 (CEST)
Date: Thu, 28 Aug 2003 00:39:59 +0200
From: Thomas Quinot <thomas@FreeBSD.ORG>
To: Matt <matt@xtaz.co.uk>
Message-ID: <20030827223959.GB64218@melusine.cuivre.fr.eu.org>
References: <200308241328.h7ODSjwC067165@spider.deepcore.dk>
	<hk4n9l.hl0s3y@webmail.xtaz.co.uk>
	<20030825014824.GA6311@melusine.cuivre.fr.eu.org>
	<hk63ml.k5h2g3@webmail.xtaz.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <hk63ml.k5h2g3@webmail.xtaz.co.uk>
User-Agent: Mutt/1.4i
X-message-flag: WARNING! Using Outlook can damage your computer.
cc: freebsd-current@FreeBSD.ORG
Subject: Re: HEADS UP! ATAng committed
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Aug 2003 22:40:01 -0000

Le 2003-08-25, Matt écrivait :

> Fatal trap 12: page fault while in kernel mode
> fault virtual address = 0x0
> fault code = supervisor write, page not present
> instruction pointer = 0x8:0xc015e59e
> stack pointer = 0x10:0xd717bac0
> frame pointer = 0x10:0xd717bacc
> code segment = base 0x0, limit 0xfffff, type 0x1b
>              = DPL 0, pres 1, def32 1, gran 1
> processor eflags = interrupt enabled, resume, IOPL = 0
> current process = 18 (swi3: cambio)
> kernel: type 12 trap, code=0
> Stopped at  free_hcb+0x2e: movl %eax,0(%edx)

OK, trivial one. Thanks to all who contributed feedback on this issue.

Thomas.

Index: atapi-cam.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/atapi-cam.c,v
retrieving revision 1.20
diff -u -r1.20 atapi-cam.c
--- atapi-cam.c	24 Aug 2003 17:48:05 -0000	1.20
+++ atapi-cam.c	27 Aug 2003 22:35:56 -0000
@@ -465,9 +465,10 @@
 	if ((ccb_h->flags & CAM_DIR_MASK) == CAM_DIR_IN && (len & 1)) {
 	    /* ATA always transfers an even number of bytes */
 	    if (!(buf = hcb->dxfer_alloc = malloc(++len, M_ATACAM,
-						  M_NOWAIT | M_ZERO)))
+						  M_NOWAIT | M_ZERO))) {
 		printf("cannot allocate ATAPI/CAM buffer\n");
 		goto action_oom;
+	    }
 	}
 	request->device = dev;
 	request->driver = hcb;

-- 
    Thomas.Quinot@Cuivre.FR.EU.ORG