From owner-freebsd-current Sun Mar 16 21:25:36 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 509DC37B401; Sun, 16 Mar 2003 21:25:35 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id C800043F85; Sun, 16 Mar 2003 21:25:34 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id B5CEF2ED402; Sun, 16 Mar 2003 21:25:34 -0800 (PST) Date: Sun, 16 Mar 2003 21:25:34 -0800 From: Alfred Perlstein To: sam@freebsd.org Cc: imp@freebsd.org, current@freebsd.org Subject: Re: wi driver Message-ID: <20030317052534.GO4145@elvis.mu.org> References: <20030317051920.GN4145@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030317051920.GN4145@elvis.mu.org> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Alfred Perlstein [030316 21:19] wrote: > um.. > ... 840 _FLAGS_OUTRANGE) { 841 WI_UNLOCK(sc); 842 return; 843 } 844 KASSERT((ifp->if_flags & IFF_OACTIVE) == 0, 845 ("wi_start: if_flags %x\n", ifp->if_flags)); 846 847 memset(&frmhdr, 0, sizeof(frmhdr)); > > What's up here? It's a race, we shouldn't be inspecting the ifp without a lock. I think this kassert should be removed. Do you guys concurr? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message