Date: Tue, 22 May 2018 05:29:08 +0000 (UTC) From: Kubilay Kocak <koobs@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r470596 - head/textproc/py-docutils Message-ID: <201805220529.w4M5T8Dj061995@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: koobs Date: Tue May 22 05:29:07 2018 New Revision: 470596 URL: https://svnweb.freebsd.org/changeset/ports/470596 Log: textproc/py-docutils: Fix/improve console scripts packaging Remove custom script symlink/packaging routine (and pkg-plist) that adds versions without .py filename suffix, in favour of what upstream provides by default. The manually maintained script list in the port was incomplete, so not all scripts were processed, producing an inconsistent experience (if not POLA violation) for users, and proves the mechanism itself is difficult to keep up-to-date and accurate. Additionally, all upstream documentation refers to these tools by their suffixed names. While I'm here: - Pet potlint (USES/USE_* order) - Add test target to make future QA easier/more thorough. Approved by: koobs (python, maintainer) Deleted: head/textproc/py-docutils/pkg-plist Modified: head/textproc/py-docutils/Makefile Modified: head/textproc/py-docutils/Makefile ============================================================================== --- head/textproc/py-docutils/Makefile Tue May 22 05:24:38 2018 (r470595) +++ head/textproc/py-docutils/Makefile Tue May 22 05:29:07 2018 (r470596) @@ -3,7 +3,7 @@ PORTNAME= docutils PORTVERSION= 0.14 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= textproc python MASTER_SITES= CHEESESHOP PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -17,19 +17,22 @@ LICENSE_COMB= multi PORTSCOUT= limit:^[0-9\.]*$$ NO_ARCH= yes -USE_PYTHON= autoplist concurrent distutils + USES= python +USE_PYTHON= autoplist concurrent distutils OPTIONS_DEFINE= PYGMENTS -PYGMENTS_DESC= Syntax highlighting -PYGMENTS_RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pygments>=1.6:textproc/py-pygments@${FLAVOR} -SCRIPTS= rst2html rst2latex rst2man rst2odt rst2odt_prepstyles \ - rst2pseudoxml rst2s5 rst2xetex rst2xml rstpep2html +PYGMENTS_DESC= Syntax highlighting +PYGMENTS_RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pygments>=1.6:textproc/py-pygments@${PY_FLAVOR} -post-install: -.for script in ${SCRIPTS} - ${LN} -s ${script}.py-${PYTHON_VER} ${STAGEDIR}${PREFIX}/bin/${script} -.endfor +.include <bsd.port.pre.mk> -.include <bsd.port.mk> +do-test: +.if ${PYTHON_VER} < 3 + @cd ${WRKSRC}/test && ${PYTHON_CMD} alltests.py +.else + @cd ${WRKSRC}/test3 && ${PYTHON_CMD} alltests.py +.endif + +.include <bsd.port.post.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805220529.w4M5T8Dj061995>