From owner-freebsd-net@freebsd.org Tue Oct 16 01:55:07 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 303F910D558B; Tue, 16 Oct 2018 01:55:07 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A535E71929; Tue, 16 Oct 2018 01:55:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-io1-xd2b.google.com with SMTP id s6-v6so4974246ioa.11; Mon, 15 Oct 2018 18:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=sNoNWVkZ4DvLoKqfl3G1x23/NZJD8Pp/7IQbGfLydKM=; b=WPmVqwweWGUOrKTx39LOnQsZn6s0LKIXWSuMBIOOHfnWZAnTNOur/ebl5RHtj8n323 x3z8RzfQ+TWK3vNHDGmyDwgRn0LIQeRufzwCIcmv3L45mtZ3dFbRq4Ms4ktknyREbDMv k/NvlZgg4w1lSVR0YWr6t7oH/eAtS6329mPs1hkUBtZlptBPELzj231AWu4Wr6/0XOph NMl/FppXpkNVbxCuMNJeSLZONSlc9jZIeBEAU/mDTfOjUsoiOMZ+eVGu74VJjkhZbJc2 qoKOo0GysRmGaz5Cni1XYEGL8tQnkBx5WnH+ZOh9YO+1IZJQOQEo8ghP8CABAF7ngrPI y3WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=sNoNWVkZ4DvLoKqfl3G1x23/NZJD8Pp/7IQbGfLydKM=; b=U+vqJDc2PWRxLPaKal1HpH590i7eKCjsMz1QlaHjBey1DaJ8dTwxNKH8irEaXUoCf0 ftJD7Y6DjFV3TWtkseYW9ashPqAiLdZyn/4NJYp8YWO/ltdKQw6Ryef0eoG8q2L3Zu7M T1Ld8jolA5yehkeVMMQRPf4qUBNe9rDt0UOftHYGIkbVjppLIDXxz37VDgEKlo0B894o Kc644s47B55ytEA8ldn7KdkvF1gh1a1xJR6SY9rWkUngIvl+s1m6RmsB73k2dnx0vvlG CATjafkQnM+BsS/iVTSlXYd/ON4K3VzrFnEXzvzOsBFb0b7Elv9N8E5YsjUUYtZ6oRwm YdCg== X-Gm-Message-State: ABuFfojQ5zHK8hronvHLhhqEHn69NyvtVKOL18/Wc1NStCs5x/bcMkm/ A+kSJuvJVI4ivV0aqfRoaWo3H4Ec X-Google-Smtp-Source: ACcGV63AZtMNn/REtXvH/THTra5VuATEHucworajWTamciXRgu/bYfU4I7ySYvpKx4pKUg0MPC2FPQ== X-Received: by 2002:a6b:2b89:: with SMTP id r131-v6mr13212294ior.256.1539654905859; Mon, 15 Oct 2018 18:55:05 -0700 (PDT) Received: from ?IPv6:2620:10d:c096:13f:fd36:d2a8:151a:af2? ([2620:10d:c090:380::2:c7ca]) by smtp.gmail.com with ESMTPSA id c8-v6sm3621216iok.9.2018.10.15.18.55.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Oct 2018 18:55:05 -0700 (PDT) From: "Enji Cooper (yaneurabeya)" Message-Id: <659BA879-AC2D-438C-9182-EE0D3650817C@gmail.com> Content-Type: multipart/signed; boundary="Apple-Mail=_38728E3A-302A-4A8C-B58B-C940A83C647E"; protocol="application/pgp-signature"; micalg=pgp-sha256 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code Date: Mon, 15 Oct 2018 18:55:02 -0700 In-Reply-To: <20181015131045.GX1044@FreeBSD.org> Cc: FreeBSD Current , freebsd-net , Jonathan Looney To: Gleb Smirnoff References: <20181015022518.GV1044@FreeBSD.org> <1B58488D-8615-40E8-9115-E26496A6DBCE@gmail.com> <20181015131045.GX1044@FreeBSD.org> X-Mailer: Apple Mail (2.3445.9.1) X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 01:55:07 -0000 --Apple-Mail=_38728E3A-302A-4A8C-B58B-C940A83C647E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 15, 2018, at 6:10 AM, Gleb Smirnoff = wrote: >=20 > Enji, >=20 > can you please check that with this patch all your tests pass? Hi Gleb! It almost compiled. I just needed to dereference the `so` = pointer: $ git diff /usr/src/sys/kern/kern_sendfile.c diff --git a/sys/kern/kern_sendfile.c b/sys/kern/kern_sendfile.c index 438069aa721..50404ce5745 100644 --- a/sys/kern/kern_sendfile.c +++ b/sys/kern/kern_sendfile.c @@ -526,6 +526,8 @@ sendfile_getsock(struct thread *td, int s, struct = file **sock_fp, *so =3D (*sock_fp)->f_data; if ((*so)->so_type !=3D SOCK_STREAM) return (EINVAL); + if (SOLISTENING(*so)) + return (ENOTCONN); return (0); } After I applied that and rebuilt the kernel, it doesn=E2=80=99t = panic anymore (and it fails with the correct errno). Thank you so very much :)! -Enji --Apple-Mail=_38728E3A-302A-4A8C-B58B-C940A83C647E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5bk3FaGcY5rvqmb79YOpJmkwhhUFAlvFRPYACgkQ9YOpJmkw hhVo9Q/+I2/wI5Ub43TCqbeQ6wBbdXupoc6Au6ZcVi9l8ltTvvtFnh+PYBRWIurW DfkWHUOhTWYi8pZpCjPftEW18SmF29iie06MWPk7eP/McOMj2rPuLz5JzahI5iwG OtRyZNU1DGj9Q34S2FVqKFmNR4Q8rB3vjy6IdAAFxA9ZmdG+YbqUGmx2pb7uuFzz XdbQ8B+G2kpGdIDnKNy16EPQSxT6C6oWxUUwX2trOk1jyQRi1YL0f0hGr4KqwTY/ 6NNbzenJicswmYHbArU81O+3JwtEezGM2OzIDNJkpE0YdQXaShr4PHuUanPcO7w5 XiiLIsW6HhvCzTYPBchYd08gnsN/WrhF8qCSIbXK5U0spz1yZj/Z7vIy+U3sgyDD sc2ClyxxznHMlM0GOek21EOfPVeXAphbhnr80maDq8L41Ju8fpFmllIHClveREb5 ou/WTIT/kQvtVd8igV7lZi0cFoM/v1bd5pXLbO0Tj+4KcJLNYjBo9T3CaY8Xi0O6 OTWOKw3IrpP09+Gmp6zntC33R3uYoe5sLOaYg8j9n2hsqJypCzeG4uESBj78h/29 XjttdW66rAXVZ7Oox6BK4rcM2x5lqPBZZjygQuZ0R3n+dd2fsDVqAlCIxiIhO2Sc tuHDCIaQgVB0s1GgRb83fO/U5L3VXPRa1YYB4PffWDXVaaEdDmk= =TwvW -----END PGP SIGNATURE----- --Apple-Mail=_38728E3A-302A-4A8C-B58B-C940A83C647E--