From owner-svn-src-head@FreeBSD.ORG  Fri May 10 07:42:35 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 1BD2E798; Fri, 10 May 2013 07:42:35 +0000 (UTC)
Date: Fri, 10 May 2013 07:42:35 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Eitan Adler <eadler@FreeBSD.org>
Subject: Re: svn commit: r250430 - head/sbin/dmesg
Message-ID: <20130510074235.GA19945@FreeBSD.org>
References: <201305100342.r4A3gmc9080595@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201305100342.r4A3gmc9080595@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 May 2013 07:42:35 -0000

On Fri, May 10, 2013 at 03:42:48AM +0000, Eitan Adler wrote:
> New Revision: 250430
> URL: http://svnweb.freebsd.org/changeset/base/250430
> 
> @@ -79,15 +80,20 @@ main(int argc, char *argv[])
>  	kvm_t *kd;
>  	size_t buflen, bufpos;
>  	long pri;
> -	int all, ch;
> +	int ch, clear;
> +	bool all;
>  
> -	all = 0;
> +	all = false;
> +	clear = false;
>  	(void) setlocale(LC_CTYPE, "");

It's a bit weird that you've left the cast here...

> @@ -190,12 +196,16 @@ main(int argc, char *argv[])
>  		(void)strvisx(visbp, p, nextp - p, 0);
>  		(void)printf("%s", visbp);

... and here (also: notice inconsistent spacing),

>  	}
> +	if (clear)
> +		if (sysctlbyname("kern.msgbuf_clear", NULL, NULL, &clear, sizeof(int)))
> +			err(1, "sysctl kern.msgbuf_clear");
> +
>  	exit(0);
>  }
>  
>  void
>  usage(void)
>  {
> -	(void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n");
> +	fprintf(stderr, "usage: dmesg [-ac] [-M core [-N system]]\n");

but removed it here for no particular reason.

./danfe