From nobody Wed Jan 5 20:13:03 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4602B1937792; Wed, 5 Jan 2022 20:13:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTgdr0JwFz4m2t; Wed, 5 Jan 2022 20:13:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DF35C12E10; Wed, 5 Jan 2022 20:13:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 205KD3V4024210; Wed, 5 Jan 2022 20:13:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 205KD3HJ024209; Wed, 5 Jan 2022 20:13:03 GMT (envelope-from git) Date: Wed, 5 Jan 2022 20:13:03 GMT Message-Id: <202201052013.205KD3HJ024209@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Motin Subject: git: ce881170088c - main - atkbd: Disable periodic polling by default. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ce881170088c4c98c036fe561f8ee8413c2e2585 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641413584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OyR4LQJ9P+9t6N2oE3a02hNyYJD/DJtVYxT5DLNX0SA=; b=e5XEqJoUz+gnVNUezv/RMJQgftoJvh/lEY5QCFCRvX/vG+zaATJIpIjuHyTBB1JLbcnLIK ItvM50hlYSh9CXE+Tq1cl861Xggii3VNvCFB3RHs80BTykQFucSmvIgNp2Ox9KEoIWKNs0 Q92R7DctMd4vb/Bvp3Ddzj0v8zpsdpQAaRDLcbKtga35PtXkAzCTqwrHsdMy9nMduCK8WB OWZlonoTWSnY9pCr342U+pnIJaMMRc53e/VXgpU3Rf/dkGbfMXeF1FB6oJY0dQ1gWugWX0 BwbzdF5TmbLU9OBH2EdaYA3fEQZWtI5MTESnaJN5HDDN/fPw43mMC11m9tXDQQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641413584; a=rsa-sha256; cv=none; b=eAX79pKraoQgddHbhuOjMFZGxAhnxBgxq/BcrXunlI80EoZvLtL/EYiNLk2YT7yXSM2ave uhFllah6RaxKYBer9YCZe9pJYmbYNQUyECiDPMF/ZJq7HPvBDCKewv7bZV7zQnVOwGfqR4 RuVGEuICa9zCHnhqOJpBR6FEToczluJ1ynbVjcFopfLY2DKStKUzSIxT1NeXnKM4jrWcDc O+xgpWhDSYvF11X+Vn01SoZyYiuBXyBNb8b8L80GhZSIOw9dqAVreK0D/7WAG8Uabgx3Pk 32ZS5VfpsJuMCkAAVMdziFunhc9Uv3jx3PRqoniudcRZBZPkUJlHNGpc5i+zrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=ce881170088c4c98c036fe561f8ee8413c2e2585 commit ce881170088c4c98c036fe561f8ee8413c2e2585 Author: Alexander Motin AuthorDate: 2022-01-05 20:00:36 +0000 Commit: Alexander Motin CommitDate: 2022-01-05 20:12:58 +0000 atkbd: Disable periodic polling by default. It is one of the few remaining Giant-locked callouts. It would be good to remove it, not mentioning that polling itself is not good. If this cause keyboard/mouse freezes on some hardware, please set loader tunable hw.atkbd.hz=1 as workaround and report the issue. Submitted by: imp, jhb --- sys/dev/atkbdc/atkbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/atkbdc/atkbd.c b/sys/dev/atkbdc/atkbd.c index cee1207df973..e87e5591150c 100644 --- a/sys/dev/atkbdc/atkbd.c +++ b/sys/dev/atkbdc/atkbd.c @@ -77,7 +77,7 @@ typedef struct atkbd_state { static SYSCTL_NODE(_hw, OID_AUTO, atkbd, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, "AT keyboard"); -static int atkbdhz = 1; +static int atkbdhz = 0; SYSCTL_INT(_hw_atkbd, OID_AUTO, hz, CTLFLAG_RWTUN, &atkbdhz, 0, "Polling frequency (in hz)");