Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jan 2006 18:41:53 +0200
From:      "Ion-Mihai "IOnut" Tetcu" <itetcu@people.tecnik93.com>
To:        "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
Subject:   ports/92554: [MAINTAINER] net-im/kpopup: security update to 0.9.8.2
Message-ID:  <1138639313.44602@it.buh.tecnik93.com>
Resent-Message-ID: <200601301650.k0UGo2m2078164@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         92554
>Category:       ports
>Synopsis:       [MAINTAINER] net-im/kpopup: security update to 0.9.8.2
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 30 16:50:01 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Ion-Mihai "IOnut" Tetcu
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
Tecnik'93 
>Environment:


System: FreeBSD 6.0-STABLE #1: Mon Jan 23 00:45:10 EET 2006



>Description:


Update to 0.9.8.2 which fixes security issues described in: ports/92359 (which
VuXML entry it is mentioned here and it would be nice if it would be committed
instead of the PR).

Change RUN_DEPENDS on net/samba3 because we need smbclient.
Drop USE_REINPLACE, no longer needed.

pkg-messae moved to files/pkg-message.in
Removed files/patch-kpopup_misc.h and handle the subtitutions via REINPLACE_CMD.

Security:		ports/92359, http://vuxml.freebsd.org/1613db79-8e52-11da-8426-000fea0a9611.html

Tinderbox log:	http://people.tecnik93.com/~itetcu/FreeBSD/ports/kpopup/build_logs/kpopup-0.9.8.2.-i386-6-.log.bz2



>How-To-Repeat:





>Fix:


--- kpopup-0.9.1_4_to_0.9.8.2.diff begins here ---
diff -urN kpopup_FPT/Makefile kpopup/Makefile
--- kpopup_FPT/Makefile	Thu Jan 26 12:34:27 2006
+++ kpopup/Makefile	Mon Jan 30 16:17:07 2006
@@ -4,32 +4,37 @@
 #
 # $FreeBSD: ports/net-im/kpopup/Makefile,v 1.10 2006/01/26 10:34:27 garga Exp $
 #
-# $Tecnik: ports/net-im/kpopup/Makefile,v 1.2 2006/01/25 23:29:03 itetcu Exp $
+# $Tecnik: ports/net-im/kpopup/Makefile,v 1.8 2006/01/30 14:17:07 itetcu Exp $
 #
 
 PORTNAME=	kpopup
-PORTVERSION=	0.9.1
-PORTREVISION=	4
+PORTVERSION=	0.9.8.2
 CATEGORIES=	net-im kde
-MASTER_SITES=	http://www.henschelsoft.de/kpopup/
+MASTER_SITES=	http://www.henschelsoft.de/kpopup/ \
+		http://people.tecnik93.com/~itetcu/FreeBSD/ports/${PORTNAME}/sources/
 
 MAINTAINER=	itetcu@people.tecnik93.com
 COMMENT=	KDE program for sending and receiving MS Windows WinPopup messages
 
-RUN_DEPENDS=	smbclient:${PORTSDIR}/net/samba
+RUN_DEPENDS=	smbclient:${PORTSDIR}/net/samba3
+
+SUB_FILES=	pkg-message
 
 USE_KDELIBS_VER=3
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_TARGET=
-USE_REINPLACE=	yes
+
+KPOPUP_DIR=	/var/tmp/kpopup
 
 post-patch:
-	@${REINPLACE_CMD} -e 's,malloc.h,stdlib.h,' ${WRKSRC}/kpopup/misc.cpp \
-		${WRKSRC}/kpopup/make_popup.cpp ${WRKSRC}/kpopup/main.cpp
-	@${REINPLACE_CMD} -e 's,%%LOCALBASE%%,${LOCALBASE},' ${WRKSRC}/kpopup/misc.h
+	@${REINPLACE_CMD} -e 's,malloc.h,stdlib.h,' ${WRKSRC}/src/make_popup.cpp
+	@${REINPLACE_CMD} -e 's,malloc.h,stdlib.h,' ${WRKSRC}/admin/ltmain.sh
+	@${REINPLACE_CMD} "s^/usr/bin^${LOCALBASE}/bin^; s^/var/lib/kpopup^${KPOPUP_DIR}^" \
+		${WRKSRC}/src/misc.h
 
 post-install:
-	@${CAT} ${PKGMESSAGE} | ${SED} -e 's,%%PREFIX%%,${PREFIX},g'
+	@${MKDIR} ${KPOPUP_DIR} && ${CHMOD} 777 ${KPOPUP_DIR}
+	@${CAT} ${PKGMESSAGE}
 
 .include <bsd.port.mk>
diff -urN kpopup_FPT/distinfo kpopup/distinfo
--- kpopup_FPT/distinfo	Wed Mar 31 06:10:02 2004
+++ kpopup/distinfo	Mon Jan 30 16:15:44 2006
@@ -1,2 +1,3 @@
-MD5 (kpopup-0.9.1.tar.gz) = 0fe30038ce7785ec533fd90a61a79b91
-SIZE (kpopup-0.9.1.tar.gz) = 527306
+MD5 (kpopup-0.9.8.2.tar.gz) = f3cb22df62c4062dd172dd28aa92d4db
+SHA256 (kpopup-0.9.8.2.tar.gz) = 50e4affc4cd401561b3142248a96febf9146851fe2e5429492a7fb6218e77491
+SIZE (kpopup-0.9.8.2.tar.gz) = 546981
diff -urN kpopup_FPT/files/patch-kpopup_misc.h kpopup/files/patch-kpopup_misc.h
--- kpopup_FPT/files/patch-kpopup_misc.h	Wed May  7 17:19:44 2003
+++ kpopup/files/patch-kpopup_misc.h	Thu Jan  1 02:00:00 1970
@@ -1,11 +0,0 @@
---- ./kpopup/misc.h.orig	Sun Aug 26 17:44:03 2001
-+++ ./kpopup/misc.h	Mon May  5 09:47:04 2003
-@@ -20,7 +20,7 @@
- #include "kpopup.h"
- 
- #undef DEBUG
--#define SMBPATH "/usr/bin" //Path of smbclient
-+#define SMBPATH "%%LOCALBASE%%/bin" //Path of smbclient
- #define TMPPOPUPFILE "/tmp/kpopup-message"
- #define SETSIG(sig, fun, fla)	sa.sa_handler = fun; \
-     sa.sa_flags = fla; \
diff -urN kpopup_FPT/files/pkg-message.in kpopup/files/pkg-message.in
--- kpopup_FPT/files/pkg-message.in	Thu Jan  1 02:00:00 1970
+++ kpopup/files/pkg-message.in	Mon Jan 30 16:17:41 2006
@@ -0,0 +1,9 @@
+--------------------------------------------------------------------------
+
+NOTE: To be able to receive messages with KPopup, you need to change your
+Samba configuration file (smb.conf): locate the [global] section in the
+configuration file, and add the following line:
+
+message command = sh -c 'export DISPLAY:0; %%PREFIX%%/bin/kpopup %s %f;' &
+
+---------------------------------------------------------------------------
diff -urN kpopup_FPT/pkg-message kpopup/pkg-message
--- kpopup_FPT/pkg-message	Wed Apr 30 16:20:05 2003
+++ kpopup/pkg-message	Thu Jan  1 02:00:00 1970
@@ -1,5 +0,0 @@
-NOTE: To be able to receive messages with KPopup, you need to change your
-Samba configuration file (smb.conf): locate the [global] section in the
-configuration file, and add the following line:
-
-message command = sh -c 'export DISPLAY:0; %%PREFIX%%/bin/kpopup %s %f;' &
diff -urN kpopup_FPT/pkg-plist kpopup/pkg-plist
--- kpopup_FPT/pkg-plist	Wed Apr 30 16:20:05 2003
+++ kpopup/pkg-plist	Mon Jan 30 16:15:44 2006
@@ -1,18 +1,20 @@
 bin/kpopup
-share/applnk/Applications/kpopup.desktop
+bin/receivepopup.sh
+share/applications/kde/kpopup.desktop
 share/icons/hicolor/16x16/apps/kpopup.png
 share/icons/hicolor/32x32/apps/kpopup.png
 share/icons/hicolor/48x48/apps/kpopup.png
 share/icons/locolor/16x16/apps/kpopup.png
 share/icons/locolor/32x32/apps/kpopup.png
 share/locale/de/LC_MESSAGES/kpopup.mo
-%%PORTDOCS%%share/doc/HTML/en/kpopup/common
+share/locale/fr/LC_MESSAGES/kpopup.mo
+share/locale/nb/LC_MESSAGES/kpopup.mo
+share/locale/es/LC_MESSAGES/kpopup.mo
 %%PORTDOCS%%share/doc/HTML/en/kpopup/index-1.html
 %%PORTDOCS%%share/doc/HTML/en/kpopup/index-2.html
 %%PORTDOCS%%share/doc/HTML/en/kpopup/index-3.html
 %%PORTDOCS%%share/doc/HTML/en/kpopup/index-4.html
-%%PORTDOCS%%share/doc/HTML/en/kpopup/index.cache.bz2
-%%PORTDOCS%%share/doc/HTML/en/kpopup/index.docbook
 %%PORTDOCS%%share/doc/HTML/en/kpopup/index.html
 %%PORTDOCS%%share/doc/HTML/en/kpopup/logotp3.png
-@dirrm share/doc/HTML/en/kpopup
+%%PORTDOCS%%@dirrm share/doc/HTML/en/kpopup
+@dirrmtry /var/tmp/kpopup
--- kpopup-0.9.1_4_to_0.9.8.2.diff ends here ---



>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1138639313.44602>