From nobody Thu Sep 25 07:55:26 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cXQxV6fj0z685H8; Thu, 25 Sep 2025 07:55:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cXQxV4Wc3z3V5T; Thu, 25 Sep 2025 07:55:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758786926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xnBgEssCrFM+YxQawInQvBVxG1SIiwrZWFveIlMdRcQ=; b=YU72iolwbBv1TqlWlyfst+QFXB8BBOeX9GxjxE2q5ntlQM1hcJZfJvvBvntR1J7ZneY4xb 3a1VuT1072W1V4Zm648cbsBGRB2gZooo2kk4TV2vqxTlt0xYTkzymazU8LCCdk7pU883NE ToTwBXDtluetvwOjbcrXjNJiO+z0cl7K4OiqdVhr8BgmS4Jl6ZC0KfHmDbvd4dxRNO0Sgf XthjoaWqb9WjQLUCerrSsDXJQWjczsijhu3QqpCCBmaqiU+ad7ujvlRHzaGM39yJAqBLNq t3lA5YfaZIoba1hwzixtHovRV5ThzVX8sJUNpSVwdOAAKVV5eM7EUeDbBFXVgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758786926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xnBgEssCrFM+YxQawInQvBVxG1SIiwrZWFveIlMdRcQ=; b=Dy2v8QzRc0KJekzlj9Lo6BK3YnfePuDTYYdHibLOLAQ0FyUxfu45ojVwfkB5w/KJgf0INm g/JyYL5ZUtTMLrCZdoMkQ5h2Q5XQ+iOQcufl1qbkP/KLnt0wZMRzgmIMTh6M3qcfHrEN2F 4QsLeAuVmmRpzxZVYk8AZ1PI4xZL3ivtSEyFzZ5ME1kDnrVE3Sls0tDKSWIAtkR+8QwGAO Q2YWUKRhJtFQHqZokRDPX+1u3M5aQhCcLXADDmS0tSm6cQMI2mEqi/ANUihBwPJo5odrzy meMjNukOFMGh9XqdaCTl9a6i7O3ao4mEKJLz84ofEu+MGg9QPaw1kCoPy8SwdQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758786926; a=rsa-sha256; cv=none; b=hRbd2bXmwODBANAveJcjLHoTirdcd1ABVwNxZGH1ENU1HKPeLEc9KbA8w9K8LOsv72dR1Q nx90dhrpFDOfR52xqE/UJ92EkbCi2T1WzEzMA3fG3EqZxNDtb+U+2TE4F0jzuyzvCEiGV8 8ABUgNlBtvXCfPBm01jF4ctW5v0Sn8ADaB1u95mQive4U26Yz/9klsF7AMo1y6Lf+9gc1g 8PM1p07X9dnL+IuGt8IuTViWetOgIQyNRnY7w0jR24ecPtM+3Tmkr9p587zH/3uFXM3Id4 W7/2Vdb4XxXl6R9U0Rk1RDrumvZRYxlMmqFL6yD75d2DXvUy65Tzd2o16Yrh0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cXQxV46sMz17QF; Thu, 25 Sep 2025 07:55:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58P7tQoA060963; Thu, 25 Sep 2025 07:55:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58P7tQoP060960; Thu, 25 Sep 2025 07:55:26 GMT (envelope-from git) Date: Thu, 25 Sep 2025 07:55:26 GMT Message-Id: <202509250755.58P7tQoP060960@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Vladimir Kondratyev Subject: git: e43fbf27976d - main - u2f(4): Invert U2F_MAKE_UHID_ALIAS kernel build option List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: wulf X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e43fbf27976df17991d32c72c41e43fda66fb262 Auto-Submitted: auto-generated The branch main has been updated by wulf: URL: https://cgit.FreeBSD.org/src/commit/?id=e43fbf27976df17991d32c72c41e43fda66fb262 commit e43fbf27976df17991d32c72c41e43fda66fb262 Author: Vladimir Kondratyev AuthorDate: 2025-09-25 07:54:19 +0000 Commit: Vladimir Kondratyev CommitDate: 2025-09-25 07:54:19 +0000 u2f(4): Invert U2F_MAKE_UHID_ALIAS kernel build option This makes non-GENERIC kernel configs easier to maintain. Requested by: glebius MFC after: 2 days --- sys/amd64/conf/GENERIC | 1 - sys/arm/conf/GENERIC | 1 - sys/arm64/conf/std.dev | 1 - sys/conf/NOTES | 3 ++- sys/conf/options | 2 +- sys/dev/hid/u2f.c | 8 ++++---- sys/i386/conf/GENERIC | 1 - sys/powerpc/conf/GENERIC64 | 1 - sys/powerpc/conf/GENERIC64LE | 1 - sys/riscv/conf/GENERIC | 1 - 10 files changed, 7 insertions(+), 13 deletions(-) diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC index d5a1adb2dc65..2e41ed26403a 100644 --- a/sys/amd64/conf/GENERIC +++ b/sys/amd64/conf/GENERIC @@ -386,7 +386,6 @@ options HID_DEBUG # enable debug msgs device hid # Generic HID support device hidbus # Generic HID Bus options IICHID_SAMPLING # Workaround missing GPIO INTR support -options U2F_MAKE_UHID_ALIAS # install /dev/uhid alias for /dev/u2f/ # EFI devices device efidev # EFI pseudo-device diff --git a/sys/arm/conf/GENERIC b/sys/arm/conf/GENERIC index 26b0c7bf0294..7394f3842d43 100644 --- a/sys/arm/conf/GENERIC +++ b/sys/arm/conf/GENERIC @@ -261,7 +261,6 @@ device aw_thermal # Allwinner Thermal Sensor Controller # HID support device hid # Generic HID support device hidbus # Generic HID Bus -options U2F_MAKE_UHID_ALIAS # install /dev/uhid alias for /dev/u2f/ # Flattened Device Tree options FDT # Configure using FDT/DTB data diff --git a/sys/arm64/conf/std.dev b/sys/arm64/conf/std.dev index 719f272426dd..c5c364ffda04 100644 --- a/sys/arm64/conf/std.dev +++ b/sys/arm64/conf/std.dev @@ -115,7 +115,6 @@ device mmcsd # mmc/sd flash cards options HID_DEBUG # enable debug msgs device hid # Generic HID support device hidbus # Generic HID Bus -options U2F_MAKE_UHID_ALIAS # install /dev/uhid alias for /dev/u2f/ # Firmware device mmio_sram # Generic on-chip SRAM diff --git a/sys/conf/NOTES b/sys/conf/NOTES index c7a8862fb906..ea9b2667607e 100644 --- a/sys/conf/NOTES +++ b/sys/conf/NOTES @@ -2447,7 +2447,8 @@ device hpen # Generic pen driver device hsctrl # System controls device ps4dshock # Sony PS4 DualShock 4 gamepad driver device u2f # FIDO/U2F authenticator -options U2F_MAKE_UHID_ALIAS # install /dev/uhid alias for /dev/u2f/ +options U2F_DROP_UHID_ALIAS # Do not install /dev/uhid alias for + # /dev/u2f/ and rename driver from uhid to u2f device xb360gp # XBox 360 gamepad driver ##################################################################### diff --git a/sys/conf/options b/sys/conf/options index 66f7f2ee2d7e..b48ad1cf42cf 100644 --- a/sys/conf/options +++ b/sys/conf/options @@ -1004,7 +1004,7 @@ IICHID_DEBUG opt_hid.h IICHID_SAMPLING opt_hid.h HKBD_DFLT_KEYMAP opt_hkbd.h HIDRAW_MAKE_UHID_ALIAS opt_hid.h -U2F_MAKE_UHID_ALIAS opt_hid.h +U2F_DROP_UHID_ALIAS opt_hid.h # kenv options # The early kernel environment (loader environment, config(8)-provided static) diff --git a/sys/dev/hid/u2f.c b/sys/dev/hid/u2f.c index 39610845c5fb..08f1a5ceedba 100644 --- a/sys/dev/hid/u2f.c +++ b/sys/dev/hid/u2f.c @@ -193,7 +193,7 @@ u2f_attach(device_t dev) u2f_detach(dev); return (error); } -#ifdef U2F_MAKE_UHID_ALIAS +#ifndef U2F_DROP_UHID_ALIAS (void)make_dev_alias(sc->dev, "uhid%d", device_get_unit(dev)); #endif @@ -587,10 +587,10 @@ static device_method_t u2f_methods[] = { }; static driver_t u2f_driver = { -#ifdef U2F_MAKE_UHID_ALIAS - "uhid", +#ifdef U2F_DROP_UHID_ALIAS + "uf2", #else - "u2f", + "uhid", #endif u2f_methods, sizeof(struct u2f_softc) diff --git a/sys/i386/conf/GENERIC b/sys/i386/conf/GENERIC index ac0cc4ba74e7..06738a7ed506 100644 --- a/sys/i386/conf/GENERIC +++ b/sys/i386/conf/GENERIC @@ -343,4 +343,3 @@ options HID_DEBUG # enable debug msgs device hid # Generic HID support device hidbus # Generic HID Bus options IICHID_SAMPLING # Workaround missing GPIO INTR support -options U2F_MAKE_UHID_ALIAS # install /dev/uhid alias for /dev/u2f/ diff --git a/sys/powerpc/conf/GENERIC64 b/sys/powerpc/conf/GENERIC64 index 48f9df5b7e38..91c91d58d058 100644 --- a/sys/powerpc/conf/GENERIC64 +++ b/sys/powerpc/conf/GENERIC64 @@ -293,4 +293,3 @@ device virtio_balloon # VirtIO Memory Balloon device options HID_DEBUG # enable debug msgs device hid # Generic HID support device hidbus # Generic HID Bus -options U2F_MAKE_UHID_ALIAS # install /dev/uhid alias for /dev/u2f/ diff --git a/sys/powerpc/conf/GENERIC64LE b/sys/powerpc/conf/GENERIC64LE index 9af71f30626d..5fb9715de655 100644 --- a/sys/powerpc/conf/GENERIC64LE +++ b/sys/powerpc/conf/GENERIC64LE @@ -274,4 +274,3 @@ device virtio_balloon # VirtIO Memory Balloon device options HID_DEBUG # enable debug msgs device hid # Generic HID support device hidbus # Generic HID Bus -options U2F_MAKE_UHID_ALIAS # install /dev/uhid alias for /dev/u2f/ diff --git a/sys/riscv/conf/GENERIC b/sys/riscv/conf/GENERIC index 2ff711e80127..a8500fe80019 100644 --- a/sys/riscv/conf/GENERIC +++ b/sys/riscv/conf/GENERIC @@ -132,7 +132,6 @@ device umass # Disks/Mass storage - Requires scbus and da options HID_DEBUG # enable debug msgs device hid # Generic HID support device hidbus # Generic HID Bus -options U2F_MAKE_UHID_ALIAS # install /dev/uhid alias for /dev/u2f/ # Serial (COM) ports device uart # Generic UART driver