From owner-freebsd-bugs Sat Apr 29 00:56:54 1995 Return-Path: bugs-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA14672 for bugs-outgoing; Sat, 29 Apr 1995 00:56:54 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA14665 for ; Sat, 29 Apr 1995 00:56:41 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id RAA15638; Sat, 29 Apr 1995 17:51:52 +1000 Date: Sat, 29 Apr 1995 17:51:52 +1000 From: Bruce Evans Message-Id: <199504290751.RAA15638@godzilla.zeta.org.au> To: bugs@FreeBSD.org, mpp@mpp.com Subject: Re: kern/subr_log.c ioctl bug Sender: bugs-owner@FreeBSD.org Precedence: bulk >Could someone apply the following patch to sys/kern/subr_log.c? >It fixes the ioctl routine to not chew up massive amounts of kernel time >if an invalid ioctl is done on /dev/klog. logioctl() needs to return >an errno instead of -1 on a failed ioctl. Discovered while adapting >this code for my screen print routines. old>! return (-1); >... new>! return (EINVAL); It should return ENOTTY. Bruce