From owner-freebsd-current@FreeBSD.ORG Mon Apr 19 10:33:23 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81DC71065674 for ; Mon, 19 Apr 2010 10:33:23 +0000 (UTC) (envelope-from rpaulo@lavabit.com) Received: from karen.lavabit.com (karen.lavabit.com [72.249.41.33]) by mx1.freebsd.org (Postfix) with ESMTP id 4C33B8FC24 for ; Mon, 19 Apr 2010 10:33:23 +0000 (UTC) Received: from e.earth.lavabit.com (e.earth.lavabit.com [192.168.111.14]) by karen.lavabit.com (Postfix) with ESMTP id 8415F157568; Mon, 19 Apr 2010 05:11:02 -0500 (CDT) Received: from 172.17.12.70 (gw-eduroam-81.fc.up.pt [193.136.24.81]) by lavabit.com with ESMTP id ZT4NIBYQ5XS0; Mon, 19 Apr 2010 05:11:02 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=sqT8OGgbp8hKI3lOURTgeLV7Y/c9tIq4tXn2+0WbrWBpg/HX6oJypOamz/rH4qS2toYeq43bfYZ2fvoXFesP1d3+AuctA1OJwNlVrz+99snWvWxUEwEedXp1fq8OlacubAgU0j2bufamsQlsdxpAZ+go9zQ3JN+iYkTzsQQuoLM=; h=References:Message-Id:From:To:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Mailer:Mime-Version:Subject:Date:Cc; References: <4BCA325A.1060600@protected-networks.net> <4BCA9F44.50002@FreeBSD.org> <987831E7-4893-4F2F-B96F-A1E25BD9BCA0@freebsd.org> <4BCB03AA.1050405@FreeBSD.org> <9B82ED79-C168-482C-A3A9-26D71060BB0F@freebsd.org> <4BCBF87C.7020400@FreeBSD.org> Message-Id: From: Rui Paulo To: Alexander Motin In-Reply-To: <4BCBF87C.7020400@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Mailer: iPhone Mail (7E18) Mime-Version: 1.0 (iPhone Mail 7E18) Date: Mon, 19 Apr 2010 11:10:49 +0100 X-Mailman-Approved-At: Mon, 19 Apr 2010 11:30:29 +0000 Cc: Michael Butler , FreeBSD-Current , Rui Paulo Subject: Re: SVN rev 206755 breakage X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Apr 2010 10:33:23 -0000 On 19 Apr 2010, at 07:30, Alexander Motin wrote: > Rui Paulo wrote: >> On 18 Apr 2010, at 14:05, Alexander Motin wrote: >>> Most of AHCI controllers could also work as usual PCI ATA, but not >>> every >>> PCI ATA could work as AHCI. It would be nice to compare `pciconf - >>> lvbc` >>> output in both working (Rui) and not working (Michael) cases. >> >> ahci0@pci0:0:31:2: class=0x01018f card=0x72708086 >> chip=0x27c48086 rev=0x02 hdr=0x00 >> vendor = 'Intel Corporation' >> device = '82801GBM/GHM (ICH7-M Family) Serial ATA Storage >> Controller' >> class = mass storage >> subclass = ATA > > ^^^ > It doesn't report itself as AHCI. > >> bar [10] = type I/O Port, range 32, base 0x20d8, size 8, >> enabled >> bar [14] = type I/O Port, range 32, base 0x20fc, size 4, >> enabled >> bar [18] = type I/O Port, range 32, base 0x20d0, size 8, >> enabled >> bar [1c] = type I/O Port, range 32, base 0x20f8, size 4, >> enabled >> bar [20] = type I/O Port, range 32, base 0x2020, size 16, >> enabled >> bar [24] = type Memory, range 32, base 0x90445000, size 1024, >> enabled > > This resource (BAR(5)) is absent on Michael's system. It is needed to > work in AHCI mode, but not required for legacy PCI ATA. Probably some > kind of BIOS magic in your case makes it appear in this mode with this > chip ID. > On ICH8 and above in non-AHCI mode BAR(5) is also present, but with > different meaning (access to some SATA registers). So it may be > difficult to distinguish what exactly we have there. > >> cap 01[70] = powerspec 2 supports D0 D3 current D0 >> >> BTW, Mac OS X also uses AHCI on this controller. > > I think Mac OS X is very special beast, which could easily be tuned > for > their specific hardware. > > So I think either your patch should be either reverted, or somehow > improved to check presence of BAR(5) and may be something else on > probe > stage, but IMHO it's a kind of magic and I wouldn't be doing so. Ok I'll revert it