From owner-freebsd-current@FreeBSD.ORG Fri Oct 21 21:12:22 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42DAE106566B for ; Fri, 21 Oct 2011 21:12:22 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (m209-73.dsl.rawbw.com [198.144.209.73]) by mx1.freebsd.org (Postfix) with ESMTP id 1B0818FC22 for ; Fri, 21 Oct 2011 21:12:21 +0000 (UTC) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.14.5/8.14.5) with ESMTP id p9LLCLk9088189; Fri, 21 Oct 2011 14:12:21 -0700 (PDT) (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.14.5/8.14.5/Submit) id p9LLCLjT088188; Fri, 21 Oct 2011 14:12:21 -0700 (PDT) (envelope-from david) Date: Fri, 21 Oct 2011 14:12:21 -0700 From: David Wolfskill To: John Baldwin Message-ID: <20111021211221.GV59810@albert.catwhisker.org> References: <20111020114844.GK59810@albert.catwhisker.org> <20111020122121.GL59810@albert.catwhisker.org> <201110211636.05917.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zGa1rFMfQatMxgJk" Content-Disposition: inline In-Reply-To: <201110211636.05917.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org Subject: Re: sys/conf/newvers.sh vs. subversion-1.7 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2011 21:12:22 -0000 --zGa1rFMfQatMxgJk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 21, 2011 at 04:36:05PM -0400, John Baldwin wrote: > .... > I'm not sure what the best fix is. One could possibly always run svnvers= ion=20 > if it exists? Sure -- and use the result as long as the exit status is 0. (It's certainly possible that svnversion exists, but the sources in question aren't in a subversion working copy, after all.) I could cobble up a patch to do that, if y'all like.... Alternatively, see the more extended comments I made to Jilles' comments (to the PR) of a similar nature; . Summary: I believe that newvers.sh ought to be intrinsically SCM-agnostic. Peace, david --=20 David H. Wolfskill david@catwhisker.org Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --zGa1rFMfQatMxgJk Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk6h4DQACgkQmprOCmdXAD1PYQCbBW650tiMhmvHl3Ia/Qp6NEeN 0kIAn23B7XMNuPKCO62407FaL47InaQL =PNZe -----END PGP SIGNATURE----- --zGa1rFMfQatMxgJk--