From owner-svn-ports-all@freebsd.org Mon Oct 15 18:00:29 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35BBF10C3747; Mon, 15 Oct 2018 18:00:29 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D9E467E1DE; Mon, 15 Oct 2018 18:00:28 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 707502243E; Mon, 15 Oct 2018 14:00:28 -0400 (EDT) Received: from web1 ([10.202.2.211]) by compute4.internal (MEProxy); Mon, 15 Oct 2018 14:00:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=YoreEL9iMHREuDHuKMcEUhlPOnh17jf23i2UWSO+E os=; b=uRvhWitLSLZHy7V4iuSVMMO5PSCl+JcKvGaSvJ25D/i90aiXrYjPKnRow W2hoL8fm2CpuKVGeUShpVSNLEjEdWca3dS8hj1eIZImQdb8dV+vY+5sU4W9zLl4L IiTXo+4g//wVwkMV4tfBMnOqJm1i8qnFUC9NQ0dGg4RFpnBhX5jFbSUU5fi0J5Wi vuqGIUxDVrT2KoqevpoI1xrZzxGAOO7YTyxCeWBJ1eUDDQFgCTIpgbawFXD6H44o 0kXOxAbYKy4LSYe6huHmSHeg6mcapvhxIfMWtzrL56kctGPMjwFh96ZvHHTAaZzi 3b87lKw721paMxQB8l17BE1BChDEA== X-ME-Sender: X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id DEC9F940FA; Mon, 15 Oct 2018 14:00:27 -0400 (EDT) Message-Id: <1539626427.48461.1542806432.653B2013@webmail.messagingengine.com> From: Tobias Kortkamp To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-6804a824 Date: Mon, 15 Oct 2018 20:00:27 +0200 Subject: Re: svn commit: r482161 - head/graphics/graphviz In-Reply-To: <201810151710.w9FHAho5073399@repo.freebsd.org> References: <201810151710.w9FHAho5073399@repo.freebsd.org> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 18:00:29 -0000 On Mon, Oct 15, 2018, at 19:10, Mathieu Arnold wrote: > Author: mat > Date: Mon Oct 15 17:10:42 2018 > New Revision: 482161 > URL: https://svnweb.freebsd.org/changeset/ports/482161 > > Log: > Remove LIBRSVG2 option, it creates a dependency loop. > > It is also discouraged upstream, graphviz can create svg without it. > > Modified: > head/graphics/graphviz/Makefile (contents, props changed) > > Modified: head/graphics/graphviz/Makefile > ============================================================================== > --- head/graphics/graphviz/Makefile Mon Oct 15 16:46:32 2018 (r482160) > +++ head/graphics/graphviz/Makefile Mon Oct 15 17:10:42 2018 (r482161) > @@ -54,7 +54,7 @@ PDOCS_HTML= doc/*.html doc/info/*.gif > > USE_LDCONFIG= ${PREFIX}/lib/${PORTNAME} > > -OPTIONS_DEFINE= XPM DIGCOLA IPSEPCOLA ICONV NLS PANGOCAIRO LIBRSVG2 POPPLER \ > +OPTIONS_DEFINE= XPM DIGCOLA IPSEPCOLA ICONV NLS PANGOCAIRO POPPLER \ > ANN GTS GTK2 GDK GDK_PIXBUF GNOMEUI SMYRNA GVEDIT MING DEVIL \ > GHOSTSCRIPT PERL PHP PYTHON RUBY LUA TCL TK GUILE NVTHREADS \ > DOCS EXAMPLES > @@ -89,7 +89,6 @@ XPM_USE= XORG=xaw,xpm,xmu,xt,sm,ice,xext,x11,xau,xdmcp > ICONV_USES= iconv > NLS_USES= gettext > PANGOCAIRO_USE= GNOME=pango,cairo XORG=xrender,x11,xau,xdmcp > -LIBRSVG2_USE= GNOME=librsvg2 GL=gl,glu,glut > GTK2_USE= XORG=sm,ice,xext,xinerama,xi,xrandr,xcursor,xfixes GNOME=gtk20 > GNOMEUI_USE= GNOME=libgnomeui > SMYRNA_USE= GNOME=libglade2,pangox-compat GL=glut > @@ -121,8 +120,6 @@ IPSEPCOLA_CONFIGURE_WITH= ipsepcola > IPSEPCOLA_IMPLIES= DIGCOLA > NLS_CONFIGURE_ENABLE= nls > PANGOCAIRO_CONFIGURE_WITH= pangocairo > -LIBRSVG2_CONFIGURE_WITH= rsvg > -LIBRSVG2_IMPLIES= PANGOCAIRO > POPPLER_CONFIGURE_WITH= poppler > ANN_CONFIGURE_WITH= ann > ANN_CONFIGURE_ENV= ANN_CFLAGS=-I${LOCALBASE}/include ANN_LIBS=-lann > I always wonder with commits like this: Since LIBRSVG2_CONFIGURE_WITH is now gone, I think --without-rsvg should be added to CONFIGURE_ARGS. Otherwise if librsvg2 is installed in the build environment it will be accidentally picked up by the configure script.