From owner-svn-src-head@freebsd.org Fri Apr 1 00:05:18 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BFEE2AE5493; Fri, 1 Apr 2016 00:05:18 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AA8811B84; Fri, 1 Apr 2016 00:05:18 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (75-101-50-44.static.sonic.net [75.101.50.44]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id u3105Afg006078 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 31 Mar 2016 17:05:11 -0700 Subject: Re: svn commit: r297392 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries To: Zbigniew Bodek References: <201603291519.u2TFJuXW051571@repo.freebsd.org> <56FBE3D6.9050205@freebsd.org> <56FC0B55.1040805@freebsd.org> Cc: Ed Maste , Zbigniew Bodek , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" From: Nathan Whitehorn Message-ID: <56FDBB36.5000302@freebsd.org> Date: Thu, 31 Mar 2016 17:05:10 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Sonic-CAuth: UmFuZG9tSVYXP6NtfAuc//olIOixtrcS2PUgqPgD2VdBt0d9nMO7tyrlvjcPzbxP7Z8f1zbXLoxL/+aH+9rONoK6ukg909kZuj5woWSs7tg= X-Sonic-ID: C;Dv6XZp335RGOXMgVZbXa/Q== M;sqXTZp335RGOXMgVZbXa/Q== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 00:05:18 -0000 I seem to be wrong. In any event, we don't have any non-device-tree platforms on PowerPC anymore, so you can just make it be "pci". -Nathan On 03/31/16 01:18, Zbigniew Bodek wrote: > > Are you sure? I don't see an example of what you are writing about. > Instead I can see several other examples such as: > > dev/usb/controller/ehci_fsl.coptionalehci mpc85xx | ehci qoriq_dpaa > dev/iicbus/adm1030.coptionalpowermac windtunnel | adm1030 powermac > etc. > > Why would they do that if they could simply type: ehci mpc85xx | > qoriq_dpaa? > > Best regards > zbb > > 2016-03-30 19:22 GMT+02:00 Nathan Whitehorn >: > > I think it should be pci aim | fdt, just like the previous line > when the files lived in sys/powerpc. To conf, that evaluates as > pci && (aim || fdt). > -Nathan > > > On 03/30/16 08:55, Zbigniew Bodek wrote: >> >> Thank you Nathan. Please check out new patch in the attachment. >> >> Best regards >> zbb >> >> 2016-03-30 16:33 GMT+02:00 Nathan Whitehorn >> >: >> >> PowerPC (and SPARC) can have real OFW without FDT support. >> Adding FDT to LINT is the wrong solution: rather, it should >> switch on fdt | aim like the rest of the Open Firmware code. >> -Nathan >> >> >> On 03/30/16 01:54, Zbigniew Bodek wrote: >>> Hello Ed, >>> >>> Please check out the attached patch. For powerpc we should >>> compile-in ofwpci.c regardless of FDT option. >>> However, it seems that LINT for powerpc does not have FDT. >>> What do you thing about adding it (as can be seen in the >>> attached patch)?. This would be done in a separate commit. >>> >>> Best regards >>> zbb >>> >>> 2016-03-30 1:53 GMT+02:00 Ed Maste >> >: >>> >>> On 29 March 2016 at 15:19, Zbigniew Bodek >>> > wrote: >>> > Author: zbb >>> > Date: Tue Mar 29 15:19:56 2016 >>> > New Revision: 297392 >>> > URL: https://svnweb.freebsd.org/changeset/base/297392 >>> > >>> > Log: >>> > Reduce OFW PCI code duplication - involves ARM, PPC >>> and SPARC64 >>> >>> My 'make tinderbox' build is now failing (powerpc LINT) >>> with: >>> >>> linking kernel >>> cpcht.o: In function `cpcht_attach': >>> cpcht.c:(.text+0x17dc): undefined reference to >>> `ofw_pci_attach' >>> cpcht.o:(.data.rel+0x0): undefined reference to >>> `ofw_pci_driver' >>> grackle.o: In function `grackle_attach': >>> grackle.c:(.text+0x2dc): undefined reference to >>> `ofw_pci_attach' >>> grackle.o:(.data.rel+0x0): undefined reference to >>> `ofw_pci_driver' >>> uninorthpci.o: In function `uninorth_attach': >>> uninorthpci.c:(.text+0x68c): undefined reference to >>> `ofw_pci_attach' >>> uninorthpci.o:(.data.rel+0x0): undefined reference to >>> `ofw_pci_driver' >>> *** [kernel] Error code 1 >>> _______________________________________________ >>> svn-src-all@freebsd.org >>> mailing list >>> https://lists.freebsd.org/mailman/listinfo/svn-src-all >>> To unsubscribe, send any mail to >>> "svn-src-all-unsubscribe@freebsd.org >>> " >>> >>> >> >> > >