From owner-svn-src-all@FreeBSD.ORG Thu Mar 21 13:45:51 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CB764E32 for ; Thu, 21 Mar 2013 13:45:51 +0000 (UTC) (envelope-from peter@wemm.org) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx1.freebsd.org (Postfix) with ESMTP id 8C0F09EC for ; Thu, 21 Mar 2013 13:45:51 +0000 (UTC) Received: by mail-ve0-f172.google.com with SMTP id cz11so2474458veb.3 for ; Thu, 21 Mar 2013 06:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=google; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=3tCPohIJ8/FZSm2OIQB0KtzUHpbZytwh/qmpb/8gMIQ=; b=tynVFPObQkX84DPLvFdpTM6P82e+NKaOkOykTwjPZsSXP9gZaGJyxTcGbsjPUccKzH mKOg4MFvHTzj/QiYFj43W1QNu+kHVSX/R5QOOMr+rkOWmxBBX/3QCVLHCb25xzpsv6TL JfRRj8vb9PBc3NrUaeYb9i58Yj8WmFwqX62DU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=3tCPohIJ8/FZSm2OIQB0KtzUHpbZytwh/qmpb/8gMIQ=; b=UdvU8oUqMGCCJg+0jKFPbCNisY0XKOIctgdUPycAFIGUioJl6SVp5qmSpPeRl0u54u fZ/JB/0H7wnBgVuYvcqaXqXIIi1hWgky1u0SaZncWqtkqCt3AeJu5CQW0EI5qUG7DWLa UhxCu1Gtl88xQJIJuT/J8tGC6nf5fRM3u2e2wZX33tPTh1upqC/9EFe6tCa3ka0wECbi zE5mdeKf/Vd191UKiYOUggImyabnoFSb5UykafG8KQzYPHPiMiJKZwnIpWhtdjmrwctY /d/YdGBjBh0g2SA+p3do8fZ/JTp4SHMy+WFXEN04ptDPeImJTUNzCwSdq34hPHhtdEcu Bxzw== MIME-Version: 1.0 X-Received: by 10.52.72.137 with SMTP id d9mr11309367vdv.105.1363873550776; Thu, 21 Mar 2013 06:45:50 -0700 (PDT) Received: by 10.221.11.72 with HTTP; Thu, 21 Mar 2013 06:45:50 -0700 (PDT) In-Reply-To: <20130321130821.GV3794@kib.kiev.ua> References: <201303210725.r2L7P8Bt075389@svn.freebsd.org> <85985.1363865556.9610245778278711296@ffe8.ukr.net> <20130321130821.GV3794@kib.kiev.ua> Date: Thu, 21 Mar 2013 06:45:50 -0700 Message-ID: Subject: Re: svn commit: r248567 - head/sys/fs/nfsclient From: Peter Wemm To: Konstantin Belousov Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnCR/F5xRe/ImIHZNfLjEsoRMBqMFHIyT2qFSkSc5uc99E/Oxxs0Ps6XVRZmp6UE8/9T+wS Cc: fidaj , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2013 13:45:51 -0000 On Thu, Mar 21, 2013 at 6:08 AM, Konstantin Belousov wrote: > On Thu, Mar 21, 2013 at 01:32:36PM +0200, fidaj wrote: >> >> >> >> that commit breaks kernel built >> >> ... >> /usr/local/libexec/ccache/world/cc -O2 -pipe -fno-strict-aliasing -Werror >> -D_KERNEL -DKLD_MODULE -nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include >> /usr/obj/usr/src/sys/GENERIC/opt_global.h -I. -I@ -I@/contrib/altq >> -finline-limit=8000 --param inline-unit-growth=100 --param >> large-function-growth=1000 -fno-common -g -fno-omit-frame-pointer >> -I/usr/obj/usr/src/sys/GENERIC -mcmodel=kernel -mno-red-zone -mno-mmx >> -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding >> -fstack-protector -std=iso9899:1999 -fstack-protector -Wall >> -Wredundant-decls -Wnested-externs -Wstrict-prototypes >> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef >> -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs >> -fdiagnostics-show-option -c >> /usr/src/sys/modules/nfscl/../../fs/nfsclient/nfs_clvfsops.c >> /usr/local/libexec/ccache/world/cc -O2 -pipe -fno-strict-aliasing -Werror >> -D_KERNEL -DKLD_MODULE -nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include >> /usr/obj/usr/src/sys/GENERIC/opt_global.h -I. -I@ -I@/contrib/altq >> -finline-limit=8000 --param inline-unit-growth=100 --param >> large-function-growth=1000 -fno-common -g -fno-omit-frame-pointer >> -I/usr/obj/usr/src/sys/GENERIC -mcmodel=kernel -mno-red-zone -mno-mmx >> -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding >> -fstack-protector -std=iso9899:1999 -fstack-protector -Wall >> -Wredundant-decls -Wnested-externs -Wstrict-prototypes >> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef >> -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs >> -fdiagnostics-show-option -c >> /usr/src/sys/modules/nfscl/../../fs/nfsclient/nfs_clvnops.c >> ctfconvert -L VERSION -g nfs_diskless.o >> ctfconvert -L VERSION -g nfs_clkrpc.o >> ctfconvert -L VERSION -g nfs_clvfsops.o >> ctfconvert -L VERSION -g nfs_clsubs.o >> ctfconvert -L VERSION -g nfs_clrpcops.o >> ctfconvert -L VERSION -g nfs_clnfsiod.o >> ctfconvert -L VERSION -g nfs_clstate.o >> ctfconvert -L VERSION -g nfs_clbio.o >> ctfconvert -L VERSION -g nfs_clvnops.o >> ctfconvert -L VERSION -g nfs_clcomsubs.o >> ctfconvert -L VERSION -g nfs_clnode.o >> cc1: warnings being treated as errors >> /usr/src/sys/modules/nfscl/../../fs/nfsclient/nfs_clport.c: In function >> 'nfscl_loadattrcache': >> /usr/src/sys/modules/nfscl/../../fs/nfsclient/nfs_clport.c:364: warning: >> 'nsize' may be used uninitialized in this function >> *** [nfs_clport.o] Error code 1 >> 1 error >> *** [all] Error code 2 >> 1 error >> *** [modules-all] Error code 2 >> 2 errors >> *** [buildkernel] Error code 2 >> 1 error >> *** [buildkernel] Error code 2 >> >> Stop in /usr/src. > > ccache ? What compiler is it ? > Anyway, I committed the supposed fix in the r248581. Looks like a gcc-style message. Which version though is unclear. It is probably the usual thing where gcc can't tell if all the code paths are complete for initializing something and a false warning. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV bitcoin:188ZjyYLFJiEheQZw4UtU27e2FMLmuRBUE