From owner-svn-ports-head@FreeBSD.ORG  Mon Jan 13 08:30:04 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C8141C0A;
 Mon, 13 Jan 2014 08:30:04 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E03E108D;
 Mon, 13 Jan 2014 08:30:03 +0000 (UTC)
Received: from [192.168.0.21] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 85B8B43B8C;
 Mon, 13 Jan 2014 02:29:39 -0600 (CST)
Message-ID: <52D3A3E2.2010004@marino.st>
Date: Mon, 13 Jan 2014 09:29:22 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r338297 - head/deskutils/aspostit
References: <201312311310.rBVDAOJv097942@svn.freebsd.org>
 <20140113082141.GA8735@FreeBSD.org>
In-Reply-To: <20140113082141.GA8735@FreeBSD.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, Antoine Brodin <antoine@FreeBSD.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jan 2014 08:30:04 -0000

On 1/13/2014 09:21, Alexey Dokuchaev wrote:
> On Tue, Dec 31, 2013 at 01:10:24PM +0000, Antoine Brodin wrote:
>> New Revision: 338297
>> URL: http://svnweb.freebsd.org/changeset/ports/338297
>>
>>  do-install:
>> -	(cd ${WRKSRC} && ${INSTALL_PROGRAM} aspostit ${PREFIX}/bin)
>> -	(cd ${WRKSRC} && ${INSTALL_MAN} aspostit.1 ${MANPREFIX}/man/man1)
>> +	${INSTALL_PROGRAM} ${WRKSRC}/aspostit ${STAGEDIR}${PREFIX}/bin
>> +	${INSTALL_MAN} ${WRKSRC}/aspostit.1 ${STAGEDIR}${MANPREFIX}/man/man1
> 
> Thank you for restoring sanity of the installation commands.  Unfortunately
> we have quite a lot of these in the tree since recently, and I truly welcome
> cleaning of this mess!

This is basically, "Why take two commands for what can be done with
one?" right?  While I can see a preference for a single command, the end
result is correct on either method.

I'd classify this as "nicer style" rather than "restoring sanity".  The
original way isn't so offensive to me, especially if several commands
follow the "cd" command or if the "cd" is used to control the output of
the ${FIND} command.