From owner-cvs-all Sat Aug 21 0:44:49 1999 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 728C014D0F; Sat, 21 Aug 1999 00:44:40 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id JAA11660; Sat, 21 Aug 1999 09:43:32 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: "Brian F. Feldman" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_physio.c In-reply-to: Your message of "Sat, 21 Aug 1999 00:26:29 PDT." Date: Sat, 21 Aug 1999 09:43:31 +0200 Message-ID: <11658.935221411@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In message , "Brian F. Feldman" writes: >On Fri, 20 Aug 1999, Poul-Henning Kamp wrote: > >> phk 1999/08/20 23:48:17 PDT >> >> Modified files: >> sys/kern kern_physio.c >> Log: >> Detect if the the offset used to read from a raw device loose bits >> when converted to block number. >> >> Revision Changes Path >> 1.37 +8 -2 src/sys/kern/kern_physio.c > >- bp->b_blkno = btodb(uio->uio_offset); >+ blockno = uio->uio_offset >> DEV_BSHIFT; >+ bp->b_blkno = blockno; >+ if (bp->b_blkno != blockno) { > ^- How can this comparison ever fail? They're different sizes. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message