From owner-freebsd-arch Thu Mar 28 13:30:36 2002 Delivered-To: freebsd-arch@freebsd.org Received: from beastie.mckusick.com (beastie.mckusick.com [209.31.233.184]) by hub.freebsd.org (Postfix) with ESMTP id C197C37B41A for ; Thu, 28 Mar 2002 13:30:12 -0800 (PST) Received: from beastie.mckusick.com (localhost [127.0.0.1]) by beastie.mckusick.com (8.11.6/8.11.6) with ESMTP id g2SLU8D99368; Thu, 28 Mar 2002 13:30:08 -0800 (PST) (envelope-from mckusick@beastie.mckusick.com) Message-Id: <200203282130.g2SLU8D99368@beastie.mckusick.com> To: Ollivier Robert Subject: Re: [PATCH] MFC the full filesystem softupdates fix ? Cc: arch@FreeBSD.ORG In-Reply-To: Your message of "Thu, 28 Mar 2002 12:10:07 +0100." <20020328111007.GC48070@caerdonn.eurocontrol.fr> Date: Thu, 28 Mar 2002 13:30:08 -0800 From: Kirk McKusick Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Date: Thu, 28 Mar 2002 12:10:07 +0100 From: Ollivier Robert To: Kirk McKusick Cc: arch@FreeBSD.ORG Subject: Re: [PATCH] MFC the full filesystem softupdates fix ? In-Reply-To: <200203272134.g2RLYTD97258@beastie.mckusick.com> According to Kirk McKusick: > If it was easy as your patch, there would be no problem in > putting it in. The problem is that -current does not have > the code to maintain the fs_pendingblocks variable. At a > minimum you would have to add that code as well. It is a > good deal more extensive, though at this point well enough I've now seen that... > tested that I am less fearful of adding it. If we take into consideration the fact that 5.0-R won't be there till October/November, do you think it would be possible to put that fix and maybe snapshots into 4-STABLE? The is no chance that snapshots would move into -current. They touch thousands of lines of code. If you want to pull over the pending block changes, I enclose the relevent delta below. Kirk McKusick =-=-=-=-=-=-= From: Kirk McKusick Date: Tue, 8 May 2001 00:42:20 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/ufs/ffs fs.h softdep.h ffs_softdep.c ffs_softdep_stub.c ffs_inode.c ffs_vfsops.c src/sys/ufs/ufs ufs_extern.h inode.h ufs_inode.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-committers@FreeBSD.org mckusick 2001/05/08 00:42:20 PDT Modified files: sys/ufs/ffs fs.h softdep.h ffs_softdep.c ffs_softdep_stub.c ffs_inode.c ffs_vfsops.c sys/ufs/ufs ufs_extern.h inode.h ufs_inode.c Log: When running with soft updates, track the number of blocks and files that are committed to being freed and reflect these blocks in the counts returned by statfs (and thus also by the `df' command). This change allows programs such as those that do news expiration to know when to stop if they are trying to create a certain percentage of free space. Note that this change does not solve the much harder problem of making this to-be-freed space available to applications that want it (thus on a nearly full filesystem, you may still encounter out-of-space conditions even though the free space will show up eventually). Hopefully this harder problem will be the subject of a future enhancement. Revision Changes Path 1.22 +4 -2 src/sys/ufs/ffs/fs.h 1.12 +6 -3 src/sys/ufs/ffs/softdep.h 1.94 +59 -2 src/sys/ufs/ffs/ffs_softdep.c 1.16 +10 -1 src/sys/ufs/ffs/ffs_softdep_stub.c 1.71 +3 -1 src/sys/ufs/ffs/ffs_inode.c 1.153 +37 -4 src/sys/ufs/ffs/ffs_vfsops.c 1.34 +2 -1 src/sys/ufs/ufs/ufs_extern.h 1.34 +4 -5 src/sys/ufs/ufs/inode.h 1.36 +3 -1 src/sys/ufs/ufs/ufs_inode.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message