From owner-freebsd-hackers@freebsd.org Mon Jan 1 18:52:12 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3AFFDEB734E for ; Mon, 1 Jan 2018 18:52:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F273F77B00 for ; Mon, 1 Jan 2018 18:52:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id 87so42917010ior.5 for ; Mon, 01 Jan 2018 10:52:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=sK0jdou5+NSh/Yuzl/9+qJjS5HgQ1S2qVgxOmdZJxho=; b=ns47/lu2ZHd1PmAMD3ZvW8e0JRPKBmkd0baC+zmB6VqCr2Ds6OLYuZTixNK4nQY++C sMOKb//jYmv2WwHKuoUtqbGBy/FvQ90fkZVzq6IQUZi1HwC5YE5u5iCrH9R/qLIiBlXn tGS7z8yTXk8ub9B3CNNyh7QVHDvL6fd3I1OUF61ljtglR5rLvqIr4Lkf07nOMLkD5sCC u7yV/u15f9+Tqm55q9nZPllqpYnV/fVTzNKePn2RWDiHV45ApSVJvaLN71LxjE24HF2g lNHW4AV84q586Qu1lGGGW4RR3tyd8g4zyid86JEvXllaQ9bEZIc6xjsifsJKf1bx9IXY Mu4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=sK0jdou5+NSh/Yuzl/9+qJjS5HgQ1S2qVgxOmdZJxho=; b=VwR+Y6hxF95l8tRal4dwhxqyUOyOVGbhrMdMj44OlxxZA41UfU6YCgd135mXaZu5Fy WhgvxPcv2vdmZGl/tbRwl4vbXLmtgUdB5/Nf6N0Gz0ZTEQyLOEaNE7ODkgqeamhhtKe/ b5nqRlRCEi1IEF9zjKuYYXvoNJ/5PEylj378QZp41M38mPMutIJ+zhTVnySCfuOlttg4 pQoa5VOpuVPpVs36021F4SVLtVPs2OxhgMiCsTdOtzGj76Lu5NQs3gu/LtZdazme6LjX iAQDTS/6O5yz0pQtjVmFGDaeFZFzlBOC7cRVZmeevl1DFbP/Vb6ioWmXqsDf/2Fd7TVS VPaQ== X-Gm-Message-State: AKGB3mL89Ss0xPniChCaccOUgcIrFau+YCOkhEtnuOSNL3xMjF/8S2T+ 4dyuq4yF7HA+Yqc2uBrPLebRvHrrjWpNbANOI50McznY X-Google-Smtp-Source: ACJfBovuUASyAeXL3fskcz2IndNcBgFfcnlmwlCFeXVOo5ejY+TIzeaTb80oRYhVUkztE/SNhB9SmGCMPq6AXOpIT/M= X-Received: by 10.107.13.67 with SMTP id 64mr12467200ion.301.1514832730841; Mon, 01 Jan 2018 10:52:10 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Mon, 1 Jan 2018 10:52:10 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201801011755.w01HtOtD087353@pdx.rh.CN85.dnsmgr.net> References: <20180101165718.GI4678@mcvoy.com> <201801011755.w01HtOtD087353@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Mon, 1 Jan 2018 11:52:10 -0700 X-Google-Sender-Auth: tYnTc1dGMdPuyC4KpOdsHJ3Iigc Message-ID: Subject: Re: Is it considered to be ok to not check the return code of close(2) in base? To: "Rodney W. Grimes" Cc: Larry McVoy , FreeBSD Hackers , Poul-Henning Kamp Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jan 2018 18:52:12 -0000 On Mon, Jan 1, 2018 at 10:55 AM, Rodney W. Grimes < freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote: > > On Mon, Jan 01, 2018 at 08:52:57AM -0800, Rodney W. Grimes wrote: > > > > On Mon, Jan 01, 2018 at 04:14:33PM +0000, Poul-Henning Kamp wrote: > > > > > But this is bikeshedding at this point anyway. > > > > > > > > +1 > > > > > > Bike shedding is good, people learn things from it. I never knew that > > > assert was altered by NDEBUG for example, thanks for that enlightenment > > > > Um, does the FreeBSD man page not start like the Linux man page with > > > > If the macro NDEBUG was defined at the moment > was last > > included, the macro assert() generates no code, and hence does > nothing > > at all. > > > > ? > > It further says that an assert() appeared in V6, and I bet that NDEBUG > didnt exist at that time. http://www.tuhs.org/cgi-bin/utree.pl?file=V7/usr/include/assert.h says by at least v7 it was there. The man page appears to be incorrect that it appeared in V6 unix, as I can find no file named *assert* in the two distributions available at TUHS, nor could grep turn up anything on assert apart from: doc/c/c3:an assertion that when a construction of So it was definitely in V7 (I'll fix the man page), and had NDEBUG from the start. Warner