From owner-freebsd-net@FreeBSD.ORG Mon Oct 12 23:59:13 2009 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D0E81065676 for ; Mon, 12 Oct 2009 23:59:13 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 0B27E8FC14 for ; Mon, 12 Oct 2009 23:59:12 +0000 (UTC) Received: (qmail 4231 invoked by uid 399); 12 Oct 2009 23:59:12 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 12 Oct 2009 23:59:12 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD3C2CC.8000607@FreeBSD.org> Date: Mon, 12 Oct 2009 16:59:08 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: volker@vwsoft.com References: <20090913042742.GA32897@svzserv.kemerovo.su> <4AAD12BE.1090600@vwsoft.com> In-Reply-To: <4AAD12BE.1090600@vwsoft.com> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: multipart/signed; micalg=pgp-ripemd160; protocol="application/pgp-signature"; boundary="------------enig7DB70B8037AE66A409CF57B0" Cc: Eugene Grosbein , net@freebsd.org Subject: Re: host(1) coredumps X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2009 23:59:13 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7DB70B8037AE66A409CF57B0 Content-Type: multipart/mixed; boundary="------------030505000504020106040800" This is a multi-part message in MIME format. --------------030505000504020106040800 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable volker@vwsoft.com wrote: > On 09/13/09 06:27, Eugene Grosbein wrote: >> Hi! >> >> For 8.0-BETA3: >> >> % host -l grosbein.pp.ru. ns2.rucable.net. >> ; Transfer failed. >> /usr/local/src/lib/bind/isc/../../../contrib/bind9/lib/isc/unix/socket= =2Ec:2486: >> REQUIRE((((sock) !=3D ((void *)0)) && (((const isc__magic_t *)(sock))-= >magic >> =3D=3D ((('I') << 24 | ('O') << 16 | ('i') << 8 | ('o')))))) failed. >> zsh: abort (core dumped) host -l grosbein.pp.ru. ns2.rucable.net. >> >> Shoud I send PR? >> >> Eugene Grosbein >=20 > Eugene, >=20 > the attached patch works around the error for me. As this is contribute= d > code, it should be fixed upstream (no need to file a PR). Can Eugene, Volker, and anyone else affected by this please try this very-lightly-modified version of the patch and confirm that it works? If so, I will get this in ASAP. Doug --=20 Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ --------------030505000504020106040800 Content-Type: text/plain; name="dighost.c.diff2" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="dighost.c.diff2" Index: dighost.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- dighost.c (revision 198000) +++ dighost.c (working copy) @@ -2604,10 +2604,12 @@ =20 if (sevent->result =3D=3D ISC_R_CANCELED) { debug("in cancel handler"); - isc_socket_detach(&query->sock); - sockcount--; - INSIST(sockcount >=3D 0); - debug("sockcount=3D%d", sockcount); + if (query->sock !=3D NULL) { + isc_socket_detach(&query->sock); + sockcount--; + INSIST(sockcount >=3D 0); + debug("sockcount=3D%d", sockcount); + } query->waiting_connect =3D ISC_FALSE; isc_event_free(&event); l =3D query->lookup; --------------030505000504020106040800-- --------------enig7DB70B8037AE66A409CF57B0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEAREDAAYFAkrTws8ACgkQyIakK9Wy8PsX9wCg8O0PlhSkUFsoWGAJ+cPKrYL7 ByQAmwTR4zx4601TSlAz7H/TtxEJ0vNm =HWxw -----END PGP SIGNATURE----- --------------enig7DB70B8037AE66A409CF57B0--