From owner-svn-src-projects@freebsd.org Sat Aug 27 01:37:37 2016 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B194A94C9E for ; Sat, 27 Aug 2016 01:37:37 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id F1EC8990; Sat, 27 Aug 2016 01:37:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id E9F5F1AB4; Sat, 27 Aug 2016 01:37:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id ABFFD24214; Sat, 27 Aug 2016 01:37:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id MbHJNhMi_Rlx; Sat, 27 Aug 2016 01:37:33 +0000 (UTC) Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 1F7DE2420F To: Ngie Cooper , Dimitry Andric References: <201608262256.u7QMuNaZ037409@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-projects@freebsd.org" From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <51c6c0cd-8809-76d8-bc07-1079e1e7a503@FreeBSD.org> Date: Fri, 26 Aug 2016 18:37:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T9dlm0exhp0vQ0pg2lN8HHTOEtknWk3ia" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Aug 2016 01:37:37 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T9dlm0exhp0vQ0pg2lN8HHTOEtknWk3ia Content-Type: multipart/mixed; boundary="pXSd53idcXRAmD5CcmeTFmNDbpMmNiEoF" From: Bryan Drewery To: Ngie Cooper , Dimitry Andric Cc: "src-committers@freebsd.org" , "svn-src-projects@freebsd.org" Message-ID: <51c6c0cd-8809-76d8-bc07-1079e1e7a503@FreeBSD.org> Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang References: <201608262256.u7QMuNaZ037409@repo.freebsd.org> In-Reply-To: --pXSd53idcXRAmD5CcmeTFmNDbpMmNiEoF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/26/2016 5:58 PM, Ngie Cooper wrote: > On Fri, Aug 26, 2016 at 4:39 PM, Dimitry Andric wrote= : > ... >> I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the >> latter didn't work for builds which are started during bootstrap-tools= =2E >> So I locally reverted all these changes before committing this WIP. >> >> That said, ${SRCTOP} makes it look a little nicer, but there are lots >> of other instances of using ../../.. in these Makefiles. It does not >> really bother me. :) >=20 > Can you use something like this instead to signal the "right intent", > and someday hopefully this will just work (tm) with a bit more effort? > Thanks, > -Ngie >=20 > # XXX: SRCTOP isn't available until Y stage in the build > SRCTOP?=3D ${.CURDIR:H:H} > LLVM_SRCS=3D ${SRCTOP}/contrib/llvm >=20 SRCTOP should work just fine here. He did note that 'the latter' (OBJTOP) wouldn't work, since the early build likely is getting a normal build OBJTOP/tmp value for OBJTOP since it builds with MAKEOBJDIRPREFIX=3D${WORLDTMP} --=20 Regards, Bryan Drewery --pXSd53idcXRAmD5CcmeTFmNDbpMmNiEoF-- --T9dlm0exhp0vQ0pg2lN8HHTOEtknWk3ia Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXwO7dAAoJEDXXcbtuRpfPnGkH+wYrfrzeIzGjZ6/mob3GFyCH sH0e2iHsiLJe+hNl/FN8QdE48CCAcI9N/p4bVsUcfOlldYNcrhr3EGKW7auoioek l8mhS9FmbsCP4yFp3Q08JO7jYRfEqPGb8pXDsncO5ligF1s5588zsByEsklWkljN tCNGE6OKEz90IEFQDfXL5UWQvuiGKgDjgsayrhp+eCGpwO9KjnDJuq9LH6HBuENe TtylCdVtCEAQNJ+mOTwYzlJhhAGAuMSZbjgrwGPe7ndcdjTGP16lBWJXMvIBOOrN 1qcG3vezd2ptezlRXQ6eX7m9T7KDHB/neQUTq3td6DfjjsbqZzGKjLN0XdwqVKc= =rEjI -----END PGP SIGNATURE----- --T9dlm0exhp0vQ0pg2lN8HHTOEtknWk3ia--