Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Feb 2018 21:06:41 +0000 (UTC)
From:      Eugene Grosbein <eugen@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r461020 - in head/emulators/virtualbox-ose: . files
Message-ID:  <201802052106.w15L6f2R076729@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eugen
Date: Mon Feb  5 21:06:41 2018
New Revision: 461020
URL: https://svnweb.freebsd.org/changeset/ports/461020

Log:
  emulators/virtualbox-ose: remove extra dependency on cdrtools.
  
  Dependency on cdrtools was introduced 6 years ago for sake of mkisofs:
  https://svnweb.freebsd.org/ports/head/emulators/virtualbox-ose/Makefile?revision=274444&view=markup
  
  In fact, VirtualBox build system does not use makeisofs
  while building for FreeBSD because it does not even try to buid
  VirtualBox Additions ISO image as its documentation says
  in the Prerequisites section:
  
  	mkisofs (required only for additions which aren't supported yet)
  	=> /usr/ports/sysutils/cdrtools
  
  	https://www.virtualbox.org/wiki/FreeBSD%20build%20instructions
  
  And it never really used mkisofs.
  Drop the dependency and bump PORTREVISION.
  
  PR:		225376
  Approved by:	vbox (maintainer timeout, 2 weeks)

Modified:
  head/emulators/virtualbox-ose/Makefile
  head/emulators/virtualbox-ose/files/patch-configure

Modified: head/emulators/virtualbox-ose/Makefile
==============================================================================
--- head/emulators/virtualbox-ose/Makefile	Mon Feb  5 20:48:24 2018	(r461019)
+++ head/emulators/virtualbox-ose/Makefile	Mon Feb  5 21:06:41 2018	(r461020)
@@ -3,7 +3,7 @@
 
 PORTNAME=	virtualbox-ose
 PORTVERSION=	5.2.6
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	emulators
 MASTER_SITES=	http://download.virtualbox.org/virtualbox/${PORTVERSION}/
 DISTFILES=	VirtualBox-${PORTVERSION}${EXTRACT_SUFX} ${GUESTADDITIONS}
@@ -18,13 +18,11 @@ LICENSE_FILE=	${WRKSRC}/COPYING
 BUILD_DEPENDS=	yasm:devel/yasm \
 		xsltproc:textproc/libxslt \
 		kmk:devel/kBuild \
-		gtar:archivers/gtar \
-		cdrecord:sysutils/cdrtools
+		gtar:archivers/gtar
 LIB_DEPENDS=	libpng.so:graphics/png \
 		libxslt.so:textproc/libxslt \
 		libcurl.so:ftp/curl
-RUN_DEPENDS=	${LOCALBASE}/etc/rc.d/vboxnet:emulators/virtualbox-ose-kmod \
-		cdrecord:sysutils/cdrtools
+RUN_DEPENDS=	${LOCALBASE}/etc/rc.d/vboxnet:emulators/virtualbox-ose-kmod
 
 CPE_VENDOR=	oracle
 CPE_PRODUCT=	vm_virtualbox

Modified: head/emulators/virtualbox-ose/files/patch-configure
==============================================================================
--- head/emulators/virtualbox-ose/files/patch-configure	Mon Feb  5 20:48:24 2018	(r461019)
+++ head/emulators/virtualbox-ose/files/patch-configure	Mon Feb  5 21:06:41 2018	(r461020)
@@ -64,6 +64,15 @@
        ;;
      --with-ow-dir=*)
        WATCOM=`echo $option | cut -d'=' -f2`
+@@ -2748,7 +2754,7 @@ if [ $ONLY_ADDITIONS -eq 0 ]; then
+   # don't check for yasm for the time beeing as 0.40 and 0.50 both have known bugs
+   # [ "$OS" != "darwin" ] && check_yasm
+   [ "$OS" != "darwin"  ] && check_xsltproc
+-  [ "$OS" != "darwin"  ] && check_mkisofs
++  [ "$OS" != "darwin" -a "$OS" != "freebsd" ] && check_mkisofs
+ fi
+ 
+ # the libraries
 @@ -2803,13 +2809,20 @@ if [ $ONLY_ADDITIONS -eq 0 ]; then
    [ $WITH_PYTHON -eq 1 ] && check_python
    [ $WITH_JAVA   -eq 1 ] && check_java



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201802052106.w15L6f2R076729>