From owner-svn-ports-all@FreeBSD.ORG Tue Sep 4 11:32:48 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 31030106566C; Tue, 4 Sep 2012 11:32:48 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id E2CC78FC0C; Tue, 4 Sep 2012 11:32:46 +0000 (UTC) Received: by bkcje9 with SMTP id je9so3042778bkc.13 for ; Tue, 04 Sep 2012 04:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=rxydQE7CQ5Z4aZz5b3NObI63zIhewPrVn139d8Pa5Qo=; b=ZElLBwWE0X3EwYoCR6zlHYWbuuXPMlvJfnSeFy2DSyWaOAw0VZWP+Gwo2Kf/xgBjNM +CYkcmdnil5enjEKxyiU8SenLJVbD7FrQe196DsB0dTOe+zRkcf7/Zuz2Rs/Av6nWwkl 77q5jiwX2rkfy+PEYzpzzJ0P/muh36KTAlI5it9Aqkqu1HfMXXLjrR7SbCRIUqrzf3HB tM3V7UgbSAlQBJkih3+nN8YjY99tibcN9F2mizLp0DAMBe5VsT22LW/rdXXcdOdL/7gp i57ho2LL9eNzXYvNfLI7v+VMxOAUXrTE5txU91oIXcnTSbAWc0Gee+MVUkWluuhBwWZF K04w== MIME-Version: 1.0 Received: by 10.204.8.84 with SMTP id g20mr7981979bkg.126.1346758365343; Tue, 04 Sep 2012 04:32:45 -0700 (PDT) Received: by 10.204.10.141 with HTTP; Tue, 4 Sep 2012 04:32:44 -0700 (PDT) Received: by 10.204.10.141 with HTTP; Tue, 4 Sep 2012 04:32:44 -0700 (PDT) In-Reply-To: <20120904041502.GA70861@ravenloft.kiev.ua> References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <20120904041502.GA70861@ravenloft.kiev.ua> Date: Tue, 4 Sep 2012 12:32:44 +0100 Message-ID: From: Chris Rees To: Alex Kozlov Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Florian Smeets , ports-committers@freebsd.org, Doug Barton Subject: Re: svn commit: r303626 - head/www/xpi-firebug X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2012 11:32:48 -0000 On 4 Sep 2012 05:15, "Alex Kozlov" wrote: > > On Mon, Sep 03, 2012 at 08:37:20PM -0700, Doug Barton wrote: > > On 09/03/2012 16:51, Florian Smeets wrote: > > > So I reread the complete thread (r301039 and followups) again, the > > > only problem there seems to be is pchecker complaining, > > It's a problem for anything that uses 'while read ...' to process > > those files, including portmaster. > I think it breaks all parsers that assume that distinfo is a text file > (have EoL on every line including last). > > > If you have the list of files with this problem and aren't interested > > in fixing them, pass the list along and I'll do it. > I plan to fix all occurrences of this in ports tree once every few months, > but if you wish to fix it now, here is a list: > audio/pianobar/distinfo > devel/pecl-libevent/distinfo > www/xpi-firebug/distinfo > www/xpi-showip/distinfo > www/trac-accountmanager/distinfo > mail/meta1/distinfo > net/istgt/distinfo > sysutils/fusefs-rar2fs/distinfo > Is this a diff/patch bug? Perhaps it could be fixed as well... or could its behaviour be thought of as correct? Chris