From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Feb 19 22:00:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B151A8CA for ; Wed, 19 Feb 2014 22:00:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8ABB218B0 for ; Wed, 19 Feb 2014 22:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1JM0034019013 for ; Wed, 19 Feb 2014 22:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1JM00UV019012; Wed, 19 Feb 2014 22:00:00 GMT (envelope-from gnats) Resent-Date: Wed, 19 Feb 2014 22:00:00 GMT Resent-Message-Id: <201402192200.s1JM00UV019012@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D960473A for ; Wed, 19 Feb 2014 21:50:01 +0000 (UTC) Received: from qmta14.emeryville.ca.mail.comcast.net (qmta14.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:44:76:96:27:212]) by mx1.freebsd.org (Postfix) with ESMTP id BA11C1805 for ; Wed, 19 Feb 2014 21:50:01 +0000 (UTC) Received: from omta03.emeryville.ca.mail.comcast.net ([76.96.30.27]) by qmta14.emeryville.ca.mail.comcast.net with comcast id UMP31n0040b6N64AEMq0Ss; Wed, 19 Feb 2014 21:50:00 +0000 Received: from jdc.koitsu.org ([76.102.14.35]) by omta03.emeryville.ca.mail.comcast.net with comcast id UMpz1n00T0lNtxY8PMq0an; Wed, 19 Feb 2014 21:50:00 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 9329873A3B; Wed, 19 Feb 2014 13:49:59 -0800 (PST) Message-Id: <20140219214959.9329873A3B@icarus.home.lan> Date: Wed, 19 Feb 2014 13:49:59 -0800 (PST) From: Jeremy Chadwick To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/186902: ftp/curl -- NTLM option has no effect X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Jeremy Chadwick List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Feb 2014 22:00:00 -0000 >Number: 186902 >Category: ports >Synopsis: ftp/curl -- NTLM option has no effect >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 19 22:00:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 9.2-STABLE amd64 >Organization: >Environment: System: FreeBSD icarus.home.lan 9.2-STABLE FreeBSD 9.2-STABLE #0 r260665: Tue Jan 14 19:21:13 PST 2014 root@icarus.home.lan:/usr/obj/usr/src/sys/X7SBA_RELENG_9_amd64 amd64 >Description: The NTLM option has no effect, meaning NTLM support is still enabled even if the NTLM option/checkbox is disabled. I went through the port Makefile and I see nothing wrong. The option controls use of --disable-ntlm or --enable-ntlm during configure. However, both of these flags are no-ops in curl's configure script. curl's autoconf/configure script allows flags of any kind to work, e.g. --disable-tiny-brained-marmots won't throw an error or warning. I have no idea when the curl folks removed --{disable,enable}-ntlm. If you do ./configure --help | grep -i ntlm, you'll see there are no such options, but there are some called --enable-ntlm-wb and --disable-ntlm-wb, but those appear to be related to NTLM delegation to winbind ntlm_auth (I don't know what that is). >How-To-Repeat: Building the port without NTLM support, then do curl -V and look at the Features list; NTLM support will be shown. >Fix: My fix would be to remove the NTLM option from the Makefile entirely, however I'm not sure about the NTLM vs. SSL engine logic located at lines 141 to 143. Someone may want to add something like NTLM_WB as an option, but I don't know what the necessary logics would be (for SSL, winbind checking, dependencies, etc.) for this to work. I'll leave all of this up to sunpoet@ to decide. >Release-Note: >Audit-Trail: >Unformatted: