From owner-cvs-src@FreeBSD.ORG Fri Jun 15 02:29:59 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AD9FF16A46F; Fri, 15 Jun 2007 02:29:59 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 93BFC13C45E; Fri, 15 Jun 2007 02:29:59 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 4CE501A4D88; Thu, 14 Jun 2007 19:29:29 -0700 (PDT) Received: from rot13.obsecurity.org (rot13.obsecurity.org [192.168.1.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 8F694511B4; Thu, 14 Jun 2007 22:29:57 -0400 (EDT) Received: by rot13.obsecurity.org (Postfix, from userid 1001) id 28134BE98; Thu, 14 Jun 2007 22:29:56 -0400 (EDT) Date: Thu, 14 Jun 2007 22:29:56 -0400 From: Kris Kennaway To: Randall Stewart Message-ID: <20070615022956.GA96741@rot13.obsecurity.org> References: <200706142259.l5EMx4aW053356@repoman.freebsd.org> <20070615001917.GA94743@rot13.obsecurity.org> <4671F88B.7030003@cisco.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Content-Disposition: inline In-Reply-To: <4671F88B.7030003@cisco.com> User-Agent: Mutt/1.4.2.3i Cc: Randall Stewart , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: src/sys/netinet sctp.h sctp_asconf.c sctp_asconf.h sctp_bsd_addr.c sctp_constants.h sctp_indata.c sctp_input.c sctp_lock_bsd.h sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_sysctl.c sctp_sysctl.h sctp_timer.c sctp_uio.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2007 02:29:59 -0000 --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 14, 2007 at 10:25:15PM -0400, Randall Stewart wrote: > Kris Kennaway wrote: > >On Thu, Jun 14, 2007 at 10:59:04PM +0000, Randall Stewart wrote: > > > >>rrs 2007-06-14 22:59:04 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/netinet sctp.h sctp_asconf.c sctp_asconf.h=20 > >> sctp_bsd_addr.c sctp_constants.h=20 > >> sctp_indata.c sctp_input.c=20 > >> sctp_lock_bsd.h sctp_os_bsd.h=20 > >> sctp_output.c sctp_pcb.c sctp_pcb.h=20 > >> sctp_peeloff.c sctp_sysctl.c=20 > >> sctp_sysctl.h sctp_timer.c sctp_uio.h=20 > >> sctp_usrreq.c sctputil.c sctputil.h=20 > >> sys/netinet6 sctp6_usrreq.c=20 > >> sys/conf options=20 > >> Log: > >> - Fix so ifn's are properly deleted when the ref count goes to 0. > >> - Fix so VRF's will clean themselves up when no references are around. > >> - Allow sctp_ifa to be passed into inpcb_bind, addr_mgmt_ep_sa to bypa= ss > >> normal validation checks. > >> - turn auto-asconf off for subset bound sockets > >> - Moves all logging to use KTR. This gets rid of most > >> of the logging #ifdef's with a few exceptions reducing > >> the number of config options for SCTP. > > > > > >| +#ifndef SCTP_SUBSYS_KTR > >| +#define SCTP_SUBSYS_KTR KTR_GEN > >| +#endif > > > >Brief silence after previous disapproval doesn't equal approval ;-) > > > >What was wrong with the method I suggested, namely using KTR_SUBSYS if > >a SCTP_TRACE option is included in the kernel? That is the intended > >way that events local to a particular subsystem should be handled. > > > >Kris >=20 > I asked if KTR_GEN was ok.. I can use KTR_SUBSYS.. sure.. but that > means I can't really run witness on my machine as I test.. since > witness is the only one that uses KTR_SUBSYS.. No one else uses > KTR_GEN.. why is it a problem using one. WITNESS does not use itq: #if 0 #define KTR_WITNESS KTR_SUBSYS #else #define KTR_WITNESS 0 #endif KTR_WITNESS is used for debugging of the WITNESS code itself (probably no-one has needed to use it for many years). It is a completely orthogonal purpose to yours, so they can co-exist happily. KTR_GEN is for "general events". SCTP is not a general event, it's localized events belonging to a particular subsystem. > So whats wrong with using a unused one? If you look at the history there was a big effort to reclaim these fields. Because space is at such a premium here there needs to be a strong reason for using up a spare field. SCTP does not strike me as such a reason, particularly since the alternative seems quite practical. Kris --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGcfmjWry0BWjoQKURAleEAKCO5WknWSwpZygSEvfpqFRPR1y9kgCfWs39 QvijiQ+ks3MlxwKq4SUQV5g= =62iN -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C--