Date: Wed, 29 Mar 1995 00:41:36 -0800 From: Paul Traina <pst@shockwave.com> To: Peter Dufault <dufault@hda.com> Cc: freebsd-bugs@freefall.cdrom.com Subject: Re: kern/281: messages printed when checking CD ROM device too verbose Message-ID: <199503290841.AAA00307@precipice.shockwave.com> In-Reply-To: Your message of "Wed, 29 Mar 1995 03:25:04 EST." <199503290825.DAA02000@hda.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Works for me. From: Peter Dufault <dufault@hda.com> Subject: Re: kern/281: messages printed when checking CD ROM device too verbo >>se I know this isn't quite what you'll want, but how about: > (bt0:4:0): "NEC CD-ROM DRIVE:210 1.0" is a type 5 removable SCSI 1 > cd0(bt0:4:0): CD-ROM > cd0(bt0:4:0): NOT READY csi:20,b,0,0 asc:b,0 > could not get size with: > (bt0:4:0): "NEC CD-ROM DRIVE:210 1.0" is a type 5 removable SCSI 1 > cd0(bt0:4:0): CD-ROM drive empty for devices we fully understand. The reason we still have a dangling line is that the driver is in the process of printing out the "CD-ROM [disk size]" line when the interrupt routine reports the undefined (in the SCSI-2 spec) error asc:b ascq:0. When this is something we understand then we can catch it and not log the message. In checking the code I see a buglet. The "drive empty" message is a bit presumptious - all we really know is we can't get the size. That's why I propose to change the message from "drive empty" to "could not get size". Some of checking in the ASC should let us be more explicit, but not in your case. -- Peter Dufault Real Time Machine Control and Simulation HD Associates, Inc. Voice: 508 433 6936 dufault@hda.com Fax: 508 433 5267
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199503290841.AAA00307>