From owner-cvs-all Wed Jan 24 11:51: 1 2001 Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 1DCC637B69F; Wed, 24 Jan 2001 11:50:37 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f0OJoaI16920; Wed, 24 Jan 2001 11:50:36 -0800 (PST) Date: Wed, 24 Jan 2001 11:50:36 -0800 From: Alfred Perlstein To: John Baldwin Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/osf1 osf1_misc.c osf1_signal.c Message-ID: <20010124115036.E26076@fw.wintelcom.net> References: <20010124095504.X26076@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Wed, Jan 24, 2001 at 10:41:35AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * John Baldwin [010124 10:42] wrote: > > On 24-Jan-01 Alfred Perlstein wrote: > > * John Baldwin [010124 02:28] wrote: > >> jhb 2001/01/24 02:27:11 PST > >> > >> Modified files: > >> sys/alpha/osf1 osf1_misc.c osf1_signal.c > >> Log: > >> Proc locking. > > > > I thought you said you would stop locking read only structures? > > If I know that they are read only. I don't have the entire kernel > memorized. Any feedback on the locking comments in sys/proc.h would be > welcome. Are you saying that p_cred should be (b) instead of (c)? Yes. There are races, but they happen anyway. Let's say process A is about to do a setuid and B is about to send it a signal, you might as well let them race it out because it's a race anyway. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message