From owner-svn-src-head@FreeBSD.ORG Wed Jun 10 06:16:03 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D23F7106564A; Wed, 10 Jun 2009 06:16:03 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id 523128FC15; Wed, 10 Jun 2009 06:15:58 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.3/8.14.3) with ESMTP id n5A6FvdJ050090; Wed, 10 Jun 2009 10:15:57 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Wed, 10 Jun 2009 10:15:57 +0400 (MSD) From: Dmitry Morozovsky To: Kip Macy In-Reply-To: <200906100121.n5A1LWVO089719@svn.freebsd.org> Message-ID: References: <200906100121.n5A1LWVO089719@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (woozle.rinet.ru [0.0.0.0]); Wed, 10 Jun 2009 10:15:57 +0400 (MSD) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193878 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2009 06:16:04 -0000 Kip, On Wed, 10 Jun 2009, Kip Macy wrote: KM> Author: kmacy KM> Date: Wed Jun 10 01:21:32 2009 KM> New Revision: 193878 KM> URL: http://svn.freebsd.org/changeset/base/193878 KM> KM> Log: KM> As far as I can tell systems that have less than 4GB are more often hurt KM> by prefetched than helped. On i386 systems and systems with less than 4GB, KM> prefetch is now disabled by default. I've added a prefetch enable tunable, to KM> enable prefetching for those systems. The prefetch disable tunable will continue KM> to unconditionally disable prefetching. KM> [snip] KM> +extern int zfs_prefetch_disable; KM> +extern int zfs_prefetch_enable; [snip] Before the interface is not settled in stone, don't you think simple bool zfs_prefetch tunable (defauled to what looks more reasonable to partucilar arch/memsize) is more clean and straightforward? -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------