From owner-freebsd-hackers Sat Feb 22 15:27:38 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id PAA28621 for hackers-outgoing; Sat, 22 Feb 1997 15:27:38 -0800 (PST) Received: from relay.nuxi.com (nuxi.ucdavis.edu [128.120.37.176]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id PAA28611 for ; Sat, 22 Feb 1997 15:27:33 -0800 (PST) Received: from dragon.nuxi.com (reqf-085.ucdavis.edu [128.120.253.205]) by relay.nuxi.com (8.8.4/8.6.12) with ESMTP id PAA24277; Sat, 22 Feb 1997 15:28:32 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.8.5/8.7.3) id XAA01938; Sat, 22 Feb 1997 23:27:26 GMT Message-ID: <19970222152725.UW26444@dragon.nuxi.com> Date: Sat, 22 Feb 1997 15:27:25 -0800 From: obrien@NUXI.com (David O'Brien) To: karpen@ocean.campus.luth.se (Mikael Karpberg) Cc: hackers@freebsd.org Subject: Re: cvs commit: src/contrib/gcc/config/i386 freebsd-elf.h freebsd.h References: <199702222320.AAA09172@ocean.campus.luth.se> X-Mailer: Mutt 0.60_p2-3,5,8-9 Mime-Version: 1.0 X-Disclaimer: Mutt Bites! Organization: The NUXI *BSD group X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Keyid: 34F9F9D5 In-Reply-To: <199702222320.AAA09172@ocean.campus.luth.se>; from Mikael Karpberg on Feb 23, 1997 00:20:16 +0100 Sender: owner-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Mikael Karpberg writes: > > > Add _BSD4_4 as a predefined symbol. > > > > What ever came out of this discussion? 2.2 candidate, or dead end? > > It's not really needed. What about: > > ==== myprogconfig.h ==== > > #if defined(FreeBSD) || defined(OpenBSD) || defined(NetBSD) > #define MYBSDDEF > #endif > > ======================== > > There you have your single define. It's very simple to do, and it works on > old versions of the OSes too. You missed the point. Now what happens when we have FooBSD, a take off of one of the above? Then the code breaks. > Ofcourse, I don't think it hurts to have that _BSD4_4 define either. > Only thing it does is give a very minor polution to the define namespace. I wouldn't really call it namespace polution. _* is not in the programmer's namespace. And I don't think the compiler is near exausting the number of strings in the _* namespace. -- -- David (obrien@NUXI.com -or- obrien@FreeBSD.org)