From owner-svn-src-head@freebsd.org Sun Feb 25 00:57:49 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D8A9F31B66; Sun, 25 Feb 2018 00:57:49 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com [IPv6:2a00:1450:4010:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E6FEF8066E; Sun, 25 Feb 2018 00:57:48 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x22f.google.com with SMTP id 37so17383876lfs.7; Sat, 24 Feb 2018 16:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Ng/jOK1eFDGgDQYpH2/Y2nQjhNsY/L9Dqta4WgxI0AA=; b=JWL+Q4j78ZVctle/GRNIzWGHy/5JD6S4tX8HEcOpSxjNEJfMOWWCW7b5Widhy1lbm2 OJKgx9hh2b88m4mnIi7mLH76hb0F8Nv54OjielOt3o+FYgZASCtl5R7kPX89Xg4DjblA pVH2kYRpsm+HLzg2LEuilFEad57GDRDPkfSZFnS3q8oLL1bmz0IdkEOuD+YwSit7WBMy E+taa1ZFDoLOVpSMaxS3GZcrOC/XoxhS20xrAOlo8u4nkWMaQEZT9qWvQ2Be/WqToo0G O5FG9fkkWxYYKKM0wYgwykz9KXF8x6BFiBt4AjOUGb+Mxc1fQ1VMk79a441RQjCZ45RT T4TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Ng/jOK1eFDGgDQYpH2/Y2nQjhNsY/L9Dqta4WgxI0AA=; b=BDijwXYG8yA4CFCy+UUbYE4uT1TZsOqWtn3GE+nUsv+eBoQ6tBaKQuhZN4fHyAuyqw mgxaZVYq4KkZNXjs5lnvsGDiQGFihj/MR4p9SHb1wbFDqYyAcNyEoyEjavhbZUqCD/Ix Cd0jseqhDpEFPtCJEfQyCVmdUf0hrq6cNMGEXdIjLYJ3JwluaIMdy5ghIsJgfdRPRYpM iluVn1zIgX26c+Ve5hGhTulbgKMEp7H8eeXbBFFPKhvuB54s475bXDjbpjDFtsKEqrk3 1Ipj3k/9aFO8j2ICz6blry/bU3cMcsXKp1l+8v3wnDcsgDLZPjgE27+vnscdR+KJspGF 0mkQ== X-Gm-Message-State: APf1xPAfP5qJUK5SaHth9DqrL9vXNqa7azpy7krk3B53d/FdJXFO8jwg UTxBGVmQe0A1SRdqzF7nBFxO8WygcIDtry6oG18= X-Google-Smtp-Source: AH8x226/yXBA4OuJ/fDU07esR4SV9Vzhg6CtiTDuUSLziOjrhkorfG3pIP1U8bFwGxFsPdmbSXu6mupyg0Fp6SF2P8s= X-Received: by 10.46.77.197 with SMTP id c66mr4598264ljd.116.1519520267222; Sat, 24 Feb 2018 16:57:47 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.30.66 with HTTP; Sat, 24 Feb 2018 16:57:46 -0800 (PST) In-Reply-To: References: <201802211551.w1LFpn57042314@repo.freebsd.org> From: Alan Somers Date: Sat, 24 Feb 2018 17:57:46 -0700 X-Google-Sender-Auth: 07LddJxA6h9sfWn0d4sUK7Ftup8 Message-ID: Subject: Re: svn commit: r329722 - head/cddl/usr.sbin/zdb To: "Conrad E. Meyer" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Feb 2018 00:57:49 -0000 On Sat, Feb 24, 2018 at 5:19 PM, Conrad Meyer wrote: > On Wed, Feb 21, 2018 at 8:40 PM, Alan Somers wrote: > > On Wed, Feb 21, 2018 at 8:51 AM, Alan Somers > wrote: > >> > >> Author: asomers > >> Date: Wed Feb 21 15:51:48 2018 > >> New Revision: 329722 > >> URL: https://svnweb.freebsd.org/changeset/base/329722 > >> > >> Log: > >> zdb: raise WARNS from 0 to 2 > >> > >> This has only been possible since r329694 and r329508 > >> > >> MFC after: 3 weeks > >> X-MFC-With: 329694 > >> X-MFC-With: 329508 > >> Sponsored by: Spectra Logic > >> > >> Modified: > >> head/cddl/usr.sbin/zdb/Makefile > >> > > > > Looks like I broke the build with GCC-6. > > Yep, I can confirm it's broken. I don't see a flag we can just turn > off for the GCC warning, though, so the solution might have to be > CFLAGS.gcc += -Wno-error. > > > I'll fix it, as soon as I can get > > the toolchain setup. > > The easy way is just: > > $ pkg install amd64-xtoolchain-gcc > $ make -sj$(sysctl -n hw.ncpu) buildworld CROSS_TOOLCHAIN=amd64-gcc > > Thanks, > Conrad > There seem to be 3 problems: CTASSERT, assfail, and array bounds. I've already committed a fix for CTASSERT and I'm testing an assfail fix now. The array bounds problem is harder, though. The logic is complicated, but I think it's sound. I don't know why GCC is complaining, unless maybe it thinks that an enum type is signed. If I can't find a good solution, I'll set -Wno-error as you suggest. -Alan