From owner-freebsd-bugs@FreeBSD.ORG Tue Feb 28 19:00:22 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F19116A420 for ; Tue, 28 Feb 2006 19:00:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B32A343D58 for ; Tue, 28 Feb 2006 19:00:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1SJ0JBN083244 for ; Tue, 28 Feb 2006 19:00:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1SJ0JOo083241; Tue, 28 Feb 2006 19:00:19 GMT (envelope-from gnats) Resent-Date: Tue, 28 Feb 2006 19:00:19 GMT Resent-Message-Id: <200602281900.k1SJ0JOo083241@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Antoine Brodin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B85816A422 for ; Tue, 28 Feb 2006 18:59:18 +0000 (GMT) (envelope-from antoine@peanut.dreadbsd.org) Received: from barton.dreadbsd.org (peanut.dreadbsd.org [82.67.196.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id A1B9C43D46 for ; Tue, 28 Feb 2006 18:59:17 +0000 (GMT) (envelope-from antoine@peanut.dreadbsd.org) Received: from barton.dreadbsd.org (localhost [127.0.0.1]) by barton.dreadbsd.org (8.13.4/8.13.4) with ESMTP id k1SIxEKX005053 for ; Tue, 28 Feb 2006 19:59:14 +0100 (CET) (envelope-from antoine@peanut.dreadbsd.org) Received: (from antoine@localhost) by barton.dreadbsd.org (8.13.4/8.13.1/Submit) id k1SIxDep005052; Tue, 28 Feb 2006 19:59:13 +0100 (CET) (envelope-from antoine) Message-Id: <200602281859.k1SIxDep005052@barton.dreadbsd.org> Date: Tue, 28 Feb 2006 19:59:13 +0100 (CET) From: Antoine Brodin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/93952: [netgraph][patch] memory leak in ng_tcpmss.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Antoine Brodin List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 19:00:22 -0000 >Number: 93952 >Category: kern >Synopsis: [netgraph][patch] memory leak in ng_tcpmss.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Feb 28 19:00:18 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Antoine Brodin >Release: FreeBSD 7.0-CURRENT i386 >Organization: none >Environment: System: FreeBSD barton.dreadbsd.org 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Wed Feb 22 20:15:40 CET 2006 antoine@barton.dreadbsd.org:/usr/obj/usr/src/sys/BARTON i386 >Description: This problem concerns ng_tcpmss(4). On hook disconnection, the per hook info which contains the output hook and the hook stats is not freed. >How-To-Repeat: Use the example in ng_tcpmss man page, shutdown and unload everything, then vmstat -m | grep netgraph >Fix: --- ng_tcpmss.c.diff begins here --- Index: sys/netgraph/ng_tcpmss.c =================================================================== RCS file: /home/ncvs/src/sys/netgraph/ng_tcpmss.c,v retrieving revision 1.2 diff -u -p -r1.2 ng_tcpmss.c --- sys/netgraph/ng_tcpmss.c 10 Jun 2005 12:44:21 -0000 1.2 +++ sys/netgraph/ng_tcpmss.c 28 Feb 2006 18:02:03 -0000 @@ -368,6 +368,8 @@ ng_tcpmss_disconnect(hook_p hook) priv->outHook = NULL; } + FREE(NG_HOOK_PRIVATE(hook), M_NETGRAPH); + NG_HOOK_SET_PRIVATE(hook, NULL); if (NG_NODE_NUMHOOKS(NG_HOOK_NODE(hook)) == 0) ng_rmnode_self(NG_HOOK_NODE(hook)); --- ng_tcpmss.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: