From owner-freebsd-audit  Tue Mar 27 12:34:17 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by hub.freebsd.org (Postfix) with ESMTP id 4D87837B718
	for <audit@freebsd.org>; Tue, 27 Mar 2001 12:34:14 -0800 (PST)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f2RKYB384389
	for <audit@freebsd.org>; Tue, 27 Mar 2001 22:34:11 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: audit@freebsd.org
Subject: review of nitpicks...
From: Poul-Henning Kamp <phk@freebsd.org>
Date: Tue, 27 Mar 2001 22:34:11 +0200
Message-ID: <84387.985725251@critter>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


	http://phk.freebsd.dk/patch/

Contains a "nitpicking.patch" which I wouldn't mind a review on.

20010327        nitpicking.patch

        This patch contains some virtual brucifications.  It's the
        kinds of stuff Bruce would complain about, but I guess he
        just havn't got around to it yet.

        src/sys/bio.h:
                bio->bio_bcount should be unsigned.

        src/sys/cdefs.h:
                Don't examine __GNUC__ unless it is defined.
                Don't examine __FreeBSD_cc_version unless it is defined.

        src/sys/kerne.h:
                Don't cast from enum to unsigned int.

        src/sys/linker_set.h:
                Define dummy {TEXT|DATA}_SET() if we're not __GNUC__

        src/sys/malloc.h:
                Wrap MALLOC() in do {...} while(0) like all other
                respectable macros.


--
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message