Date: Tue, 27 Mar 2001 22:34:11 +0200 From: Poul-Henning Kamp <phk@freebsd.org> To: audit@freebsd.org Subject: review of nitpicks... Message-ID: <84387.985725251@critter>
next in thread | raw e-mail | index | archive | help
http://phk.freebsd.dk/patch/ Contains a "nitpicking.patch" which I wouldn't mind a review on. 20010327 nitpicking.patch This patch contains some virtual brucifications. It's the kinds of stuff Bruce would complain about, but I guess he just havn't got around to it yet. src/sys/bio.h: bio->bio_bcount should be unsigned. src/sys/cdefs.h: Don't examine __GNUC__ unless it is defined. Don't examine __FreeBSD_cc_version unless it is defined. src/sys/kerne.h: Don't cast from enum to unsigned int. src/sys/linker_set.h: Define dummy {TEXT|DATA}_SET() if we're not __GNUC__ src/sys/malloc.h: Wrap MALLOC() in do {...} while(0) like all other respectable macros. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?84387.985725251>