From owner-cvs-all Fri Dec 3 17:18:33 1999 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id 3CE311533C; Fri, 3 Dec 1999 17:18:05 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.9.3/8.9.3) with ESMTP id SAA24676; Fri, 3 Dec 1999 18:17:45 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id SAA14552; Fri, 3 Dec 1999 18:17:45 -0700 (MST) Message-Id: <199912040117.SAA14552@harmony.village.org> To: obrien@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_bus.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Fri, 03 Dec 1999 16:57:13 PST." <19991203165713.A1939@dragon.nuxi.com> References: <19991203165713.A1939@dragon.nuxi.com> <199912031701.KAA11135@harmony.village.org> Date: Fri, 03 Dec 1999 18:17:45 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In message <19991203165713.A1939@dragon.nuxi.com> "David O'Brien" writes: : Often one does not need to do a `make world' to catch syntax errors. A : simple make of program (or kernel) would do. A `make world' is [mostly] : only needed to test interactions in the build process. One problem is that of forgotten checkins. I almost always checkin building code. However that is "building on my machine" rather than "building with a fresh set of sources." Several times I've had the problem of neglecting to checkin a change to a file that has changed/been added. Many other people have had this problem as well, and I know that the software compiles for them. There are many times new source will be imported which doesn't compile, but the import must be on a vendor branch unmodified. The files are then pulled off the vendor branch and made to compile shortly after the initial commit. Finally, there have been instances where I change files foo and bar and make my commit. Bob changes files baz and boo and makes his commit. The confluance of these changes causes a problem, but each change taken singlely doesn't have the problem. This has happened in the past as well. Automating a 'it must compile to be committed' rule is hard to do, despite its desitrability. The simple fact of life is that the FreeBSD will be unbuildable from time to time and history has shown that these periods rarely last more than a few hours (although serveral days in a row snapshots may be broken by different people each day). The more mainstream the breakage (eg no kernels can be built) gets faster attention than the less mainstream (eg make release fails) due to the relative numbers of people doing each one. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message