From owner-freebsd-hackers@freebsd.org Tue Oct 6 14:19:20 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07D759B6469 for ; Tue, 6 Oct 2015 14:19:20 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id E29B1281 for ; Tue, 6 Oct 2015 14:19:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id E1CAC9B6468; Tue, 6 Oct 2015 14:19:19 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E08729B6467 for ; Tue, 6 Oct 2015 14:19:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE147280 for ; Tue, 6 Oct 2015 14:19:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Tue, 6 Oct 2015 14:19:58 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t96EJB82029523; Tue, 6 Oct 2015 08:19:11 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1444141151.66572.124.camel@freebsd.org> Subject: Re: boostrap target From: Ian Lepore To: Rui Paulo Cc: hackers@freebsd.org, NGie Cooper Date: Tue, 06 Oct 2015 08:19:11 -0600 In-Reply-To: <1444107547.6210.35.camel@me.com> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444094009.66572.105.camel@freebsd.org> <1444096463.6210.31.camel@me.com> <1444096802.66572.115.camel@freebsd.org> <1444107547.6210.35.camel@me.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 14:19:20 -0000 On Mon, 2015-10-05 at 21:59 -0700, Rui Paulo wrote: > On Mon, 2015-10-05 at 20:00 -0600, Ian Lepore wrote: > > I decided the "beforedepend: bootstrap" attempt at a fix was wrong, > > because it led to always using the precompiled/processed versions of > > the > > generated files on every pass (boostrap tools, world, crossbuilding), > > and I think that wasn't the intention. I discovered (by accident, > > actually) that there was no need to run the bootstap target at all as > > long as m4 got built before lex during the bootstrap-tools stage, so > > that's the fix I applied, and it was sufficient to build current and > > stable-10 on a stable-8 build host. > > Well, I thought that was what jkim added in 2013. Is your > BOOTSTRAPPING variable set correctly? > > diff --git a/Makefile.inc1 b/Makefile.inc1 > index 1e58f47..f0649ef 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -1206,6 +1206,10 @@ _sed= usr.bin/sed > _lex= usr.bin/lex > .endif > > +.if ${BOOTSTRAPPING} < 1000002 > +_m4= usr.bin/m4 > +.endif > + > .if ${BOOTSTRAPPING} < 1000013 > _yacc= lib/liby \ > usr.bin/yacc > @@ -1283,6 +1287,7 @@ bootstrap-tools: > usr.bin/rpcgen \ > ${_sed} \ > ${_yacc} \ > + ${_m4} \ > ${_lex} \ > lib/libmd \ > usr.bin/xinstall \ > This was necessary, but not sufficient without the dependency to ensure m4 is built before lex while parallel-building. It may be that it was sufficient in 2013, I can't remember when we added the increased parallelism in the bootstrap-tools stage. -- Ian > > > > I suppose at this point the bootstrap target, and all the pre > > -generated > > files it copies, could be deleted. Unless they're serving some other > > purpose I'm not aware of, like maybe some folks have a need to run > > that > > target manually. > > Looking again, all the GENFILES are generated by the bootstrap target > based on the rule init$f -> $f. > > However, as you say it probably should be deleted because there's no > difference between init$f and $f. >