From owner-svn-src-projects@FreeBSD.ORG Mon Mar 1 22:44:53 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4E8D106564A; Mon, 1 Mar 2010 22:44:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 759018FC1C; Mon, 1 Mar 2010 22:44:53 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 29B0B46B06; Mon, 1 Mar 2010 17:44:53 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 72D598A021; Mon, 1 Mar 2010 17:44:52 -0500 (EST) From: John Baldwin To: Roman Divacky Date: Mon, 1 Mar 2010 17:44:45 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003012130.o21LUB0I022574@svn.freebsd.org> In-Reply-To: <201003012130.o21LUB0I022574@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003011744.45410.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 01 Mar 2010 17:44:52 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.5 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204537 - in projects/clangbsd/contrib/libstdc++: include/ext src X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2010 22:44:53 -0000 On Monday 01 March 2010 4:30:11 pm Roman Divacky wrote: > Author: rdivacky > Date: Mon Mar 1 21:30:11 2010 > New Revision: 204537 > URL: http://svn.freebsd.org/changeset/base/204537 > > Log: > Make this a little more like C++. Clang++ can grok all libstdc++ > now. > > Modified: > projects/clangbsd/contrib/libstdc++/include/ext/ropeimpl.h > projects/clangbsd/contrib/libstdc++/src/locale-inst.cc > > Modified: projects/clangbsd/contrib/libstdc++/include/ext/ropeimpl.h > ============================================================================== > --- projects/clangbsd/contrib/libstdc++/include/ext/ropeimpl.h Mon Mar 1 21:04:10 2010 (r204536) > +++ projects/clangbsd/contrib/libstdc++/include/ext/ropeimpl.h Mon Mar 1 21:30:11 2010 (r204537) > @@ -382,7 +382,7 @@ _GLIBCXX_BEGIN_NAMESPACE(__gnu_cxx) > { > _Rope_RopeLeaf<_CharT, _Alloc>* __l > = (_Rope_RopeLeaf<_CharT, _Alloc>*)this; > - __l->_Rope_RopeLeaf<_CharT, _Alloc>::~_Rope_RopeLeaf(); > + __l->template _Rope_RopeLeaf<_CharT, _Alloc>::~_Rope_RopeLeaf(); > _L_deallocate(__l, 1); > break; > } Hmm, this hurts my brain to have 'template ' in the middle of a dereference. I also don't see why it should be needed. > Modified: projects/clangbsd/contrib/libstdc++/src/locale-inst.cc > ============================================================================== > --- projects/clangbsd/contrib/libstdc++/src/locale-inst.cc Mon Mar 1 21:04:10 2010 (r204536) > +++ projects/clangbsd/contrib/libstdc++/src/locale-inst.cc Mon Mar 1 21:30:11 2010 (r204537) > @@ -180,11 +180,11 @@ _GLIBCXX_END_LDBL_NAMESPACE > template class messages_byname; > > // ctype > - inline template class __ctype_abstract_base; > + template class __ctype_abstract_base; > template class ctype_byname; > > // codecvt > - inline template class __codecvt_abstract_base; > + template class __codecvt_abstract_base; > template class codecvt_byname; Perhaps try moving the 'template' before the 'inline'? Randomly dropping 'inline' isn't really ideal I think. -- John Baldwin