From owner-freebsd-arm@freebsd.org Sun Aug 18 15:21:39 2019 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 304EAC9976 for ; Sun, 18 Aug 2019 15:21:39 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46BLPZ49r1z4dNd for ; Sun, 18 Aug 2019 15:21:38 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1566141697; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=kjDnAov/Z88sdDEDkx5FEqizreDI8kCOEvXJRONRot4c8QBQkKuOr3E9CNRCfn4UbmprFq1oxc4rC hPw0fMyEy35u/YqBzz7UvShNRRgTPPUv301fOqdyBPNvQEfdN0uWYbS8tRiLgAgc8JPweD1GmHqiKC iEGvUKrKjyYsPIRE2xD8D6O0PmOykJZ7HCmymyaLQ3Bc1e9zcAzXqhPkIgimAv002LGvL7soEw0GjO 4YAjijdnyn9kInOCjALfq6ALuAuIk9v2fWMaCInfv7yk9W5WCSLyPIVg2GvZyZDy/MjPaVDW1JqBDc Z7WRSk9LEO3sX9HirCp2nYYBXWkAHEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=52rd915rP6PedWKVGZqsbXWpt3lygrQtvOnvRgqabuE=; b=EYpnMuY7yMPZsFH96oIBoxtNe52NFKGXRAvjYI7xQY8OiP4xNtoovK/DyPqR0/f56Ics6Wsv3VcH4 7V89VvpY5Wbx4wPr2zZlHgdnDWpyQH14xRw7lSNqWjLuRwRRAzmbuu1+A56HLKLjIoJRjR7GAmq2ze D+aofJ22w+zyQl5JxJQAXjjAQR/ECr3VgWlOKhdC+YcYpv30vA66thZwSEkE1eJGOEKE5Z2HQKduN9 vwfv0LKzHJbfDOLOmA9fxEwdBo4A+jlJi/euAy6RYt/UP1aVIUWwFBKdSFHwVF2OKmwkzgF1HR/bc8 dpwexj+f/47HAWm8bQqZtfVlGstLoLg== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=52rd915rP6PedWKVGZqsbXWpt3lygrQtvOnvRgqabuE=; b=f0sli1UAjiwgQQwHAGQ3nOJF4Rd48CZK4jprnjyYrbGGX4dgU6KHt9JbzmTnWf1BwNLmIMWxvSYq7 SD6IQsJX4j+IGnkjn8VXbZLfkHqgF/PUorHSBcB2yp8pTrtZt4OJeCzraww+yTpXuMMuyJnMImFhPi cL67UzK5a4WrWAVyZeOn9fgifd8kLRXddBfAiwQ55+mfaZuHBVOqBSYUksvq67AR4i9ECGrdPu6XEo e1wmNE5aHuTt9BDnoGE1jQBn/Ft+kBWbsn+eSR5NRiuXoTSZygbYO81KnQ4RcMXfEhmLA5WrQDjWUu 0GgI2vPZNJGrF+M7DYLynD73l17BbNA== X-MHO-RoutePath: aGlwcGll X-MHO-User: dbeee85c-c1cb-11e9-b67b-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id dbeee85c-c1cb-11e9-b67b-cdd75d6ce7a8; Sun, 18 Aug 2019 15:21:35 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7IFLVWb072111; Sun, 18 Aug 2019 09:21:31 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <9f0d3934c9b715696643f0ea93de8e589355a560.camel@freebsd.org> Subject: Re: Zynq qspi driver https://reviews.freebsd.org/D14698 From: Ian Lepore To: Warner Losh , Milan Obuch Cc: "freebsd-arm@freebsd.org" Date: Sun, 18 Aug 2019 09:21:31 -0600 In-Reply-To: References: <20190818121741.7bd82a63@zeta.dino.sk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46BLPZ49r1z4dNd X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Aug 2019 15:21:39 -0000 On Sun, 2019-08-18 at 08:23 -0600, Warner Losh wrote: > On Sun, Aug 18, 2019 at 4:18 AM Milan Obuch > wrote: > > > Hi, > > > > I was able to use in subject mentioned driver on my Zybo Z7 board. > > I > > just downloaded zy7_qspi.c file, put it in sys/arm/xilinx directory > > and > > all other necessary patches applied per hand to 12.0-STABLE source > > tree. > > > > I am able to read and write flash attached to qspi on my board. u- > > boot > > uses qspi flash for environment storage so some caution should be > > taken > > with that. > > > > Question: what needs to be done in order to get this driver into > > official source tree? Is there any show stopper? My experience is - > > it > > Just Works (tm). > > > > It looks almost ready to my eye. Not sure what the hold up is. > > Warner > I think I'm probably among those who dropped the ball on this. I vaguely remember that when it was submitted, I thought I was going to be buying a xilinx development board soon and I'd just test and commit it after that. But then plans changed at $work and the devel board thing never happened. -- Ian