From owner-cvs-sys Fri Nov 8 15:22:17 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA17867 for cvs-sys-outgoing; Fri, 8 Nov 1996 15:22:17 -0800 (PST) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id PAA17759; Fri, 8 Nov 1996 15:21:26 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id AAA28661; Sat, 9 Nov 1996 00:21:18 +0100 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id AAA17618; Sat, 9 Nov 1996 00:21:17 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.8.2/8.6.9) id AAA08426; Sat, 9 Nov 1996 00:15:59 +0100 (MET) From: J Wunsch Message-Id: <199611082315.AAA08426@uriah.heep.sax.de> Subject: Re: cvs commit: src/sys/scsi scsiconf.c To: max@freefall.freebsd.org (Masafumi NAKANE), akiyama@kme.mei.co.jp (Shunsuke Akiyama) Date: Sat, 9 Nov 1996 00:15:59 +0100 (MET) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199611071814.KAA08527@freefall.freebsd.org> from Masafumi NAKANE at "Nov 7, 96 10:14:05 am" X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E X-Mailer: ELM [version 2.4ME+ PL17 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Masafumi NAKANE wrote: > max 96/11/07 10:14:03 > > Modified: sys/scsi scsiconf.c > Log: > Typo, MATSHITA -> MATSUSHITA. Are you absolutely sure about this???? I.e., do you really have such a drive? The original entry was from the author of "od", and i assume it's one of the drives he's been testing this on. More importantly, i think there are actually only 8 characters available in the vendor ID of a SCSI INQUIRY command (i remember this since all the Tandberg tape drives fill the entire vendor string with "TANDBERG", and therefore start their model string with a space as in: " TDC4222"). So i'm very hesitant that you've just broken support for these devices. > 2.2 & 2.1.6 candidate. Not without further confirmation by the owner of such a device. (Cc to the author of "od", i'm not sure whether he's following the commit mails.) Please folks, do only commit things you are really certain about. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)