From owner-svn-ports-all@FreeBSD.ORG Fri Jan 24 17:34:20 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 99855BFB; Fri, 24 Jan 2014 17:34:20 +0000 (UTC) Received: from smtpout6.timeweb.ru (smtpout6.timeweb.ru [92.53.117.39]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4C78E16E1; Fri, 24 Jan 2014 17:34:20 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1W6kdu-0006yH-7w; Fri, 24 Jan 2014 21:34:10 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 3FD3DC5E; Fri, 24 Jan 2014 21:34:09 +0400 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 1D2BE9C49; Fri, 24 Jan 2014 21:34:04 +0400 (MSK) Date: Fri, 24 Jan 2014 21:34:04 +0400 From: Dmitry Marakasov To: Mathieu Arnold Subject: Re: svn commit: r340875 - head/graphics/py-pyglet Message-ID: <20140124173403.GA33026@hades.panopticon> References: <201401240125.s0O1PcNR065306@svn.freebsd.org> <02676048890BF03180E6CFAB@atuin.in.mat.cc> <20140124124924.GF28542@hades.panopticon> <08A02A920829DC4130029A7F@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <08A02A920829DC4130029A7F@ogg.in.absolight.net> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 17:34:20 -0000 * Mathieu Arnold (mat@FreeBSD.org) wrote: > | I don't think that matters unless ${WRKSRC} is deleted in the > | process. Actually, it's even better, as if for some reason some > | command leaves something behind (a corefile or a log) in it's current > | directory, it'll end up in ${WRKSRC} and to a ports' directory. > > Well, yes, but no, you're missing the point, the idea is to have a stable > and consistent way of doing things, so that if anyone needs to touch any > port, (s)he doesn't have figure out what the current directory currently is. One should _never_ depend on current directory unless he changes it in the same line. Because it's handling is (as you say) inconsistent among make versions, and because it's highly error prone (changing or reordering lines will break unrelated stuff). Also, all talk about this is useless unless whole portstree is converted and then keept consistent, which IHMO is completely useless. > I was fine before because each line was executed in its own shell, but now, > the whole bloc is executed in one shell invocation. Has this `now' happened in HEAD? Both 9.0-RELEASE and 10.0-RELEASE (after bmake switch) behave like this: % cat /tmp/Makefile all: @pwd @cd ..; pwd @pwd % make -C tmp /tmp / /tmp Although I remember having cd in one line affect pwd in another some time ago. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru