From owner-freebsd-bugs@FreeBSD.ORG  Tue Mar 28 20:40:25 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A645716A400
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 28 Mar 2006 20:40:25 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0821943D69
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 28 Mar 2006 20:40:23 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2SKeMso017785
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 28 Mar 2006 20:40:22 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2SKeMJd017784;
	Tue, 28 Mar 2006 20:40:22 GMT (envelope-from gnats)
Date: Tue, 28 Mar 2006 20:40:22 GMT
Message-Id: <200603282040.k2SKeMJd017784@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: John Baldwin <jhb@freebsd.org>
Cc: 
Subject: Re: kern/94939: [acpi] [patch] reboot(8) fails on IBM / Intel blades
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: John Baldwin <jhb@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Mar 2006 20:40:25 -0000

The following reply was made to PR kern/94939; it has been noted by GNATS.

From: John Baldwin <jhb@freebsd.org>
To: "Devon H. O'Dell" <devon.odell@gmail.com>
Cc: "Nate Lawson" <nate@root.org>, bug-followup@freebsd.org
Subject: Re: kern/94939: [acpi] [patch] reboot(8) fails on IBM / Intel blades
Date: Tue, 28 Mar 2006 15:40:36 -0500

 On Tuesday 28 March 2006 15:21, Devon H. O'Dell wrote:
 > > The patch has some other major problems that should be addressed before
 > > committing.  It should not manually be parsing the GAS and mapping
 > > memory etc.  Instead, it should just use AcpiHwLowLevelWrite():
 > >
 > > ACPI_STATUS
 > > AcpiHwLowLevelWrite (
 > >      UINT32                  Width,
 > >      UINT32                  Value,
 > >      ACPI_GENERIC_ADDRESS    *Reg);
 > >
 > > Width should be 8, value should be the reset value in the FADT, and Reg
 > > should be the FADT GAS struct.
 > 
 > Please see http://www.sitetronics.com/~dodell/acpi2.diff (also
 > attached). This addresses this issue and significantly reduces the
 > size of the diff :)
 > 
 > --Devon
 
 Maybe it should use AcpiGbl_FADT->ResetRegister.RegisterBitWidth rather
 than hardcoding 8?
 
 -- 
 John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
 "Power Users Use the Power to Serve"  =  http://www.FreeBSD.org