From owner-cvs-all Sat Aug 21 0:50:59 1999 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 94F9815456; Sat, 21 Aug 1999 00:50:54 -0700 (PDT) (envelope-from green@FreeBSD.org) Received: from localhost (green@localhost) by freefall.freebsd.org (8.9.3/8.9.2) with ESMTP id AAA56634; Sat, 21 Aug 1999 00:50:53 -0700 (PDT) (envelope-from green@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: green owned process doing -bs Date: Sat, 21 Aug 1999 00:50:52 -0700 (PDT) From: "Brian F. Feldman" To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_physio.c In-Reply-To: <11658.935221411@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sat, 21 Aug 1999, Poul-Henning Kamp wrote: > >+ bp->b_blkno = blockno; > >+ if (bp->b_blkno != blockno) { > > ^- How can this comparison ever fail? > > They're different sizes. But you set bp->b_blkno to blockno, then compare whether or not they're equal. I'm pretty sure that's not right. > > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop." > FreeBSD -- It will take a long time before progress goes too far! > > -- Brian Fundakowski Feldman / "Any sufficiently advanced bug is \ green@FreeBSD.org | indistinguishable from a feature." | FreeBSD: The Power to Serve! \ -- Rich Kulawiec / To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message