From owner-cvs-src@FreeBSD.ORG Thu Nov 11 21:30:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 58A3D16A4CE; Thu, 11 Nov 2004 21:30:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BD5243D2D; Thu, 11 Nov 2004 21:30:53 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iABLUr74044947; Thu, 11 Nov 2004 21:30:53 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iABLUrZe044946; Thu, 11 Nov 2004 21:30:53 GMT (envelope-from rwatson) Message-Id: <200411112130.iABLUrZe044946@repoman.freebsd.org> From: Robert Watson Date: Thu, 11 Nov 2004 21:30:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/nfsserver nfs_serv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2004 21:30:53 -0000 rwatson 2004-11-11 21:30:53 UTC FreeBSD src repository Modified files: sys/nfsserver nfs_serv.c Log: Correct a bug in nfsrv_create() where a call to nfsrv_access() might be made holding the NFS server mutex. To clean this up, introduce a version of the function, nfsrv_access_withgiant(), that expects the NFS server mutex to already have been dropped and Giant acquired. Wrap nfsrv_access() around this. This permits callers to more efficiently check access if they're in a code block performing VFS operations, and can be substitited for the nfsrv_access() call that triggered this bug. PR: 73807, 73208 MFC after: 1 week Revision Changes Path 1.151 +52 -38 src/sys/nfsserver/nfs_serv.c