From owner-p4-projects Fri Dec 6 14:23:55 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id EA5F437B404; Fri, 6 Dec 2002 14:23:50 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E95D37B401 for ; Fri, 6 Dec 2002 14:23:50 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E96A43E4A for ; Fri, 6 Dec 2002 14:23:50 -0800 (PST) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gB6MJNmV047974 for ; Fri, 6 Dec 2002 14:19:23 -0800 (PST) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gB6MJMxI047971 for perforce@freebsd.org; Fri, 6 Dec 2002 14:19:22 -0800 (PST) Date: Fri, 6 Dec 2002 14:19:22 -0800 (PST) Message-Id: <200212062219.gB6MJMxI047971@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson Subject: PERFORCE change 22012 for review To: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG http://perforce.freebsd.org/chv.cgi?CH=22012 Change 22012 by rwatson@rwatson_tislabs on 2002/12/06 14:18:39 Re-sort arguments to devfs_create_symlink(): all other creation calls use the credential as the first context argument, not the second. Affected files ... .. //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#368 edit .. //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#190 edit .. //depot/projects/trustedbsd/mac/sys/security/mac_lomac/mac_lomac.c#47 edit .. //depot/projects/trustedbsd/mac/sys/security/mac_mls/mac_mls.c#151 edit .. //depot/projects/trustedbsd/mac/sys/security/mac_none/mac_none.c#112 edit .. //depot/projects/trustedbsd/mac/sys/security/mac_test/mac_test.c#88 edit .. //depot/projects/trustedbsd/mac/sys/security/sebsd/sebsd.c#61 edit .. //depot/projects/trustedbsd/mac/sys/sys/mac.h#222 edit .. //depot/projects/trustedbsd/mac/sys/sys/mac_policy.h#176 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#368 (text+ko) ==== @@ -2810,11 +2810,11 @@ } void -mac_create_devfs_symlink(struct mount *mp, struct ucred *cred, +mac_create_devfs_symlink(struct ucred *cred, struct mount *mp, struct devfs_dirent *dd, struct devfs_dirent *de) { - MAC_PERFORM(create_devfs_symlink, mp, cred, dd, &dd->de_label, de, + MAC_PERFORM(create_devfs_symlink, cred, mp, dd, &dd->de_label, de, &de->de_label); } ==== //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#190 (text+ko) ==== @@ -859,7 +859,7 @@ } static void -mac_biba_create_devfs_symlink(struct mount *mp, struct ucred *cred, +mac_biba_create_devfs_symlink(struct ucred *cred, struct mount *mp, struct devfs_dirent *dd, struct label *ddlabel, struct devfs_dirent *de, struct label *delabel) { ==== //depot/projects/trustedbsd/mac/sys/security/mac_lomac/mac_lomac.c#47 (text+ko) ==== @@ -985,7 +985,7 @@ } static void -mac_lomac_create_devfs_symlink(struct mount *mp, struct ucred *cred, +mac_lomac_create_devfs_symlink(struct ucred *cred, struct mount *mp, struct devfs_dirent *dd, struct label *ddlabel, struct devfs_dirent *de, struct label *delabel) { ==== //depot/projects/trustedbsd/mac/sys/security/mac_mls/mac_mls.c#151 (text+ko) ==== @@ -829,7 +829,7 @@ } static void -mac_mls_create_devfs_symlink(struct mount *mp, struct ucred *cred, +mac_mls_create_devfs_symlink(struct ucred *cred, struct mount *mp, struct devfs_dirent *dd, struct label *ddlabel, struct devfs_dirent *de, struct label *delabel) { ==== //depot/projects/trustedbsd/mac/sys/security/mac_none/mac_none.c#112 (text+ko) ==== @@ -183,7 +183,7 @@ } static void -mac_none_create_devfs_symlink(struct mount *mp, struct ucred *cred, +mac_none_create_devfs_symlink(struct ucred *cred, struct mount *mp, struct devfs_dirent *dd, struct label *ddlabel, struct devfs_dirent *de, struct label *delabel) { ==== //depot/projects/trustedbsd/mac/sys/security/mac_test/mac_test.c#88 (text+ko) ==== @@ -561,7 +561,7 @@ } static void -mac_test_create_devfs_symlink(struct mount *mp, struct ucred *cred, +mac_test_create_devfs_symlink(struct ucred *cred, struct mount *mp, struct devfs_dirent *dd, struct label *ddlabel, struct devfs_dirent *de, struct label *delabel) { ==== //depot/projects/trustedbsd/mac/sys/security/sebsd/sebsd.c#61 (text+ko) ==== @@ -476,7 +476,7 @@ } static void -sebsd_create_devfs_symlink(struct mount *mp, struct ucred *cred, +sebsd_create_devfs_symlink(struct ucred *cred, struct mount *mp, struct devfs_dirent *dd, struct label *ddlabel, struct devfs_dirent *de, struct label *delabel) { ==== //depot/projects/trustedbsd/mac/sys/sys/mac.h#222 (text+ko) ==== @@ -175,7 +175,7 @@ struct devfs_dirent *de); void mac_create_devfs_directory(struct mount *mp, char *dirname, int dirnamelen, struct devfs_dirent *de); -void mac_create_devfs_symlink(struct mount *mp, struct ucred *cred, +void mac_create_devfs_symlink(struct ucred *cred, struct mount *mp, struct devfs_dirent *dd, struct devfs_dirent *de); int mac_create_vnode_extattr(struct ucred *cred, struct mount *mp, struct vnode *dvp, struct vnode *vp, struct componentname *cnp); ==== //depot/projects/trustedbsd/mac/sys/sys/mac_policy.h#176 (text+ko) ==== @@ -147,8 +147,8 @@ void (*mpo_create_devfs_directory)(struct mount *mp, char *dirname, int dirnamelen, struct devfs_dirent *de, struct label *label); - void (*mpo_create_devfs_symlink)(struct mount *mp, - struct ucred *cred, struct devfs_dirent *dd, + void (*mpo_create_devfs_symlink)(struct ucred *cred, + struct mount *mp, struct devfs_dirent *dd, struct label *ddlabel, struct devfs_dirent *de, struct label *delabel); int (*mpo_create_vnode_extattr)(struct ucred *cred, To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message