Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Nov 2012 14:58:44 -0500 (EST)
From:      Benjamin Kaduk <kaduk@MIT.EDU>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        svn-doc-head@freebsd.org, svn-doc-all@freebsd.org, doc-committers@freebsd.org
Subject:   Re: svn commit: r39981 - head/en_US.ISO8859-1/books/faq
Message-ID:  <alpine.GSO.1.10.1211121456040.2164@multics.mit.edu>
In-Reply-To: <201211112229.qABMT1il009287@svn.freebsd.org>
References:  <201211112229.qABMT1il009287@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 11 Nov 2012, Eitan Adler wrote:

> Author: eadler
> Date: Sun Nov 11 22:29:01 2012
> New Revision: 39981
> URL: http://svnweb.freebsd.org/changeset/doc/39981
>
> Log:
>  Reduce redundant markup and word and other minor problems reported by
>  igor.  Limited additional checking was done of the surrounding content.
>
>  Approved by:	jkois (mentor, before merge conflict resolution)
>
> Modified:
>  head/en_US.ISO8859-1/books/faq/book.xml
>
> Modified: head/en_US.ISO8859-1/books/faq/book.xml
> ==============================================================================
> --- head/en_US.ISO8859-1/books/faq/book.xml	Sun Nov 11 21:42:32 2012	(r39980)
> +++ head/en_US.ISO8859-1/books/faq/book.xml	Sun Nov 11 22:29:01 2012	(r39981)
> @@ -923,7 +923,7 @@
> 		  <para>Where the format is
> 		    <literal>html-split</literal>, the files are bundled
> 		    up using &man.tar.1;.  The resulting
> -		    <filename>.tar</filename> file is then compressed
> +		    <filename>.tar</filename> is then compressed

This would seem like a candidate where the "redundant" use of "file" 
actually is helpful, since there is not a specific file name given.

> 		    using the compression schemes detailed in the next
> 		    point.</para>
> 		</listitem>
> @@ -8741,8 +8740,8 @@ ATDT1234567</programlisting>
> 	    if the incoming data is actually a login or shell prompt.
> 	    If you have a shell prompt at the remote end, it is possible
> 	    to terminate &man.ppp.8; without dropping the line by using
> -	    the <command>close lcp</command> command (a following
> -	    <command>term</command> command) will reconnect you to the
> +	    <command>close lcp</command> (a following
> +	    <command>term</command>) will reconnect you to the

I have trouble making sense of this sentence; perhaps the close paren is 
misplaced?  Not a bug in your change, but I would have expected it to be 
noticed in pre-commit review.

> 	    shell on the remote machine.</para>
>
> 	  <para>If nothing in your log file indicates why the link might
> @@ -9054,12 +9053,12 @@ hint.sio.7.irq="12"</programlisting>
> 	  <para>When changing modes of the file hierarchies rooted in the
> 	    files instead of the files themselves,
> 	    you have to use either <option>-H</option> or
> -	    <option>-L</option> together with the <option>-R</option>
> -	    option to make this work.  See the &man.chmod.1; and
> -	    &man.symlink.7; manual pages for more info.</para>
> +	    <option>-L</option> together with <option>-R</option>
> +	    to make this work.  See &man.chmod.1; and
> +	    &man.symlink.7; for more information.</para>
>
> 	  <warning>
> -	    <para>The <option>-R</option> option does a
> +	    <para><option>-R</option> does a

My understanding was that we did not like to start sentences with markup.

-Ben Kaduk

> 	      <emphasis>recursive</emphasis> &man.chmod.1;.  Be careful
> 	      about specifying directories or symlinks to directories to
> 	      &man.chmod.1;.  If you want to change the permissions of a
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.GSO.1.10.1211121456040.2164>