From owner-freebsd-current Fri May 31 22:13: 1 2002 Delivered-To: freebsd-current@freebsd.org Received: from sccrmhc02.attbi.com (sccrmhc02.attbi.com [204.127.202.62]) by hub.freebsd.org (Postfix) with ESMTP id 4FDF037B400 for ; Fri, 31 May 2002 22:12:54 -0700 (PDT) Received: from bmah.dyndns.org ([12.233.149.189]) by sccrmhc02.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020601051253.VVNH11183.sccrmhc02.attbi.com@bmah.dyndns.org>; Sat, 1 Jun 2002 05:12:53 +0000 Received: from intruder.bmah.org (localhost [IPv6:::1]) by bmah.dyndns.org (8.12.3/8.12.3) with ESMTP id g515Crfs021310; Fri, 31 May 2002 22:12:53 -0700 (PDT) (envelope-from bmah@intruder.bmah.org) Received: (from bmah@localhost) by intruder.bmah.org (8.12.3/8.12.3/Submit) id g515CqQI021309; Fri, 31 May 2002 22:12:52 -0700 (PDT) Message-Id: <200206010512.g515CqQI021309@intruder.bmah.org> X-Mailer: exmh version 2.5+ 20020506 with nmh-1.0.4 To: Makoto Matsushita Cc: current@freebsd.org Subject: Re: Call for Review: allow sysinstall to tweak tri-value sendmail_enable In-reply-to: <20020601130758S.matusita@jp.FreeBSD.org> References: <20020601130758S.matusita@jp.FreeBSD.org> Comments: In-reply-to Makoto Matsushita message dated "Sat, 01 Jun 2002 13:07:58 +0900." From: "Bruce A. Mah" Reply-To: bmah@freebsd.org X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 31 May 2002 22:12:52 -0700 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG If memory serves me right, Makoto Matsushita wrote: > Following patch creates submenu to change the sendmail_enable value. > However, I don't know who want to set this variable to 'NO'. If > selecting 'YES' and 'NONE' is enough, I'll try to make another patch. > > Any comments? I want to push this feature to 4.6-RELEASE... Comments on the text only (i.e. I haven't tested the new menus)... Bruce. > Index: menus.c > =================================================================== > RCS file: /home/ncvs/src/usr.sbin/sysinstall/menus.c,v > retrieving revision 1.343 > diff -u -r1.343 menus.c > --- menus.c 20 May 2002 17:08:00 -0000 1.343 > +++ menus.c 31 May 2002 17:49:18 -0000 > @@ -1372,11 +1372,31 @@ > { " Rwhod", "This machine wants to run the rwho daemon", > dmenuVarCheck, dmenuToggleVariable, NULL, "rwhod_enable=YES" }, > { " Sendmail", "This machine wants to run the sendmail daemon", > - dmenuVarCheck, dmenuToggleVariable, NULL, "sendmail_enable=YES" }, > + NULL, dmenuSubmenu, NULL, &MenuSendmail }, > { " Sshd", "This machine wants to run the ssh daemon", > dmenuVarCheck, dmenuToggleVariable, NULL, "sshd_enable=YES" }, > { " TCP Extensions", "Allow RFC1323 and RFC1644 TCP extensions?", > dmenuVarCheck, dmenuToggleVariable, NULL, "tcp_extensions=YES" }, > + { NULL } }, > +}; > + > +DMenu MenuSendmail = { > + DMENU_NORMAL_TYPE | DMENU_SELECTION_RETURNS, > + "Sendmail Invocation Selection", > + "There are three options for invocating sendmail at startup.\n" s/invocating/invoking/ > + "Please select Yes if you want to use sendmail as your mail transfer\n" > + "agent. Selecting No disables sendmail to open network socket for\n" s/sendmail to open/sendmail's/ > + "incoming email, but still runs at startup. None disables sendmail\n" s/still runs at startup/still enables sendmail for outbound mail/ You will probably need to word-wrap differently after this change. > + "completely at startup.", > + NULL, > + NULL, > + { > + { " Yes", "Start sendmail", > + dmenuVarCheck, dmenuSetVariable, NULL, "sendmail_enable=YES" }, > + { " No", "Start sendmail, but don't listen from network" > , > + dmenuVarCheck, dmenuSetVariable, NULL, "sendmail_enable=NO" }, > + { " None", "Don't start any sendmail processes", > + dmenuVarCheck, dmenuSetVariable, NULL, "sendmail_enable=NONE" }, > { NULL } }, > }; > > Index: sysinstall.h > =================================================================== > RCS file: /home/ncvs/src/usr.sbin/sysinstall/sysinstall.h,v > retrieving revision 1.227 > diff -u -r1.227 sysinstall.h > --- sysinstall.h 31 May 2002 13:38:17 -0000 1.227 > +++ sysinstall.h 31 May 2002 17:49:19 -0000 > @@ -407,6 +407,7 @@ > extern DMenu MenuSysconsScrnmap; /* System console screenmap con > figuration menu */ > extern DMenu MenuSysconsTtys; /* System console terminal t > ype menu */ > extern DMenu MenuNetworking; /* Network configuration menu > */ > +extern DMenu MenuSendmail; /* Sendmail configuration menu > */ > extern DMenu MenuInstallCustom; /* Custom Installation menu > */ > extern DMenu MenuDistributions; /* Distribution menu > */ > extern DMenu MenuDiskDevices; /* Disk type devices > */ > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message