Date: Sat, 18 Feb 2012 21:03:18 -0600 From: Mark Linimon <linimon@lonesome.com> To: Doug Barton <dougb@FreeBSD.org> Cc: Michael Scheidell <michael.scheidell@secnap.com>, Andriy Gapon <avg@FreeBSD.org>, Steve Kargl <sgk@troutmask.apl.washington.edu>, Chris Rees <utisoft@gmail.com>, "freebsd-ports@FreeBSD.org" <freebsd-ports@FreeBSD.org> Subject: Re: Please test your commits Message-ID: <20120219030318.GB6927@lonesome.com> In-Reply-To: <4F403B69.9030503@FreeBSD.org> References: <d11bb0d2-36dd-4745-8661-733fccdb977b@blur> <ebd5ff06-8b41-4dc3-8bea-02972f22019d@blur> <20120217182214.GD11416@lonesome.com> <4F403B69.9030503@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 18, 2012 at 03:59:37PM -0800, Doug Barton wrote:
> Where I think reasonable minds can differ are (appropriate) responses of
> the form, "This was not done properly, here is how it can/should be done
> (better)." IMO those should *always* be public in order to help others
> who are paying attention to the same topic.
Fair enough. Perhaps I should have been more clear about the distinction
I make between constructive criticism ("this code would be more effectively
stated xyz") vs. non-constructive criticism ("your mother smells of
elderberries".) I was thinking more of the latter when I replied, perhaps
after wincing at some recent threads.
mcl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120219030318.GB6927>