From owner-freebsd-pkg@freebsd.org  Tue Feb 14 11:24:08 2017
Return-Path: <owner-freebsd-pkg@freebsd.org>
Delivered-To: freebsd-pkg@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3ED4CDF523
 for <freebsd-pkg@mailman.ysv.freebsd.org>;
 Tue, 14 Feb 2017 11:24:08 +0000 (UTC) (envelope-from des@des.no)
Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3])
 by mx1.freebsd.org (Postfix) with ESMTP id 8F5461DC6
 for <freebsd-pkg@freebsd.org>; Tue, 14 Feb 2017 11:24:08 +0000 (UTC)
 (envelope-from des@des.no)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 8EB96CDF522; Tue, 14 Feb 2017 11:24:08 +0000 (UTC)
Delivered-To: pkg@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E6B5CDF521
 for <pkg@mailman.ysv.freebsd.org>; Tue, 14 Feb 2017 11:24:08 +0000 (UTC)
 (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 544C91DC5;
 Tue, 14 Feb 2017 11:24:07 +0000 (UTC) (envelope-from des@des.no)
Received: from desk.des.no (smtp.des.no [194.63.250.102])
 by smtp.des.no (Postfix) with ESMTP id D6EFA105E9;
 Tue, 14 Feb 2017 11:24:06 +0000 (UTC)
Received: by desk.des.no (Postfix, from userid 1001)
 id 77AAF2670; Tue, 14 Feb 2017 12:22:55 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Cy Schubert <Cy.Schubert@komquats.com>
Cc: Alan Somers <asomers@freebsd.org>, scrappy@freebsd.org,
 Brian Somers <brian@freebsd.org>, freebsd-bugzilla@ayaken.net,
 Cy Schubert <cy@freebsd.org>, pkg@freebsd.org
Subject: Re: Bug 217055 - Consolidate random sleeps in periodic scripts
References: <201702140647.v1E6lVd8078946@slippy.cwsent.com>
Date: Tue, 14 Feb 2017 12:22:55 +0100
In-Reply-To: <201702140647.v1E6lVd8078946@slippy.cwsent.com> (Cy Schubert's
 message of "Mon, 13 Feb 2017 22:47:31 -0800")
Message-ID: <868tp9j9tc.fsf@desk.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: freebsd-pkg@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Binary package management and package tools discussion
 <freebsd-pkg.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-pkg>,
 <mailto:freebsd-pkg-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pkg/>
List-Post: <mailto:freebsd-pkg@freebsd.org>
List-Help: <mailto:freebsd-pkg-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-pkg>,
 <mailto:freebsd-pkg-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2017 11:24:08 -0000

Cy Schubert <Cy.Schubert@komquats.com> writes:
> +	tty >/dev/null 2>&1 && daily_ntpd_avoid_congestion=3DNO

This won't work, because && forks.  You need:

   if [ -t 0 ] ; then ... ; fi

As for the subject matter, I think it's a good idea, and if periodic
always sleeps for a random amount of time, there is no need for an
additional sleep in 480.leapfile-ntpd (and frankly, I don't like that
the current version leaves a task running in the background).

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no