From owner-svn-ports-head@freebsd.org  Sun Jul 14 03:37:48 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BC7415D5DE5;
 Sun, 14 Jul 2019 03:37:48 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2E42384F76;
 Sun, 14 Jul 2019 03:37:48 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 0338DC941; Sun, 14 Jul 2019 03:37:47 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Mark Linimon <linimon@lonesome.com>
Cc: Mark Linimon <linimon@FreeBSD.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r506432 - in head: audio/libcoverart audio/nekobi-lv2
 benchmarks/netperfmeter chinese/pyzy comms/ncid databases/postgis25
 games/diaspora graphics/gimmage graphics/pcl-pointclouds graphi...
References: <201907120225.x6C2P7b4029273@repo.freebsd.org>
 <tvbr-hpoi-wny@FreeBSD.org> <20190714031212.GB18049@lonesome.com>
Date: Sun, 14 Jul 2019 05:37:43 +0200
In-Reply-To: <20190714031212.GB18049@lonesome.com> (Mark Linimon's message of
 "Sun, 14 Jul 2019 03:12:21 +0000")
Message-ID: <lfx1-8ewo-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: 2E42384F76
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.86 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-1.00)[-0.997,0];
 NEURAL_HAM_SHORT(-0.87)[-0.867,0];
 NEURAL_HAM_LONG(-1.00)[-0.999,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jul 2019 03:37:48 -0000

Mark Linimon <linimon@lonesome.com> writes:

> On Fri, Jul 12, 2019 at 05:55:41AM +0200, Jan Beich wrote:
>
>> Mark Linimon <linimon@FreeBSD.org> writes:
>> 
>> > -.if exists(/usr/lib/libstdc++.so)
>> > +
>> > +.include <bsd.port.pre.mk>
>> > +
>> > +.if ${CHOSEN_COMPILER_TYPE} == gcc
>> >  CXXFLAGS+=	-stdlib=libstdc++
>> >  .endif
>> 
>> Which version of GCC supports -stdlib= flag?
>
> Note that didn't change the line that specifies CXXFLAGS, just the test
> around it.

CHOSEN_COMPILER_TYPE is always "clang" due to USES=objc:compiler but
Clang defaults to libc++ since FreeBSD 10.0. So, your commit probably
broke libobjc2 runtime on GCC-based architectures.

// From contrib/llvm/tools/clang/lib/Driver/ToolChains/FreeBSD.cpp:
ToolChain::CXXStdlibType FreeBSD::GetDefaultCXXStdlibType() const {
  if (getTriple().getOSMajorVersion() >= 10)
    return ToolChain::CST_Libcxx;
  return ToolChain::CST_Libstdcxx;
}